From: Andi Kleen <ak@suse.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Andi Kleen <ak@suse.de>, mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [9/9] GBPAGES: Do kernel direct mapping at boot using GB pages
Date: Thu, 31 Jan 2008 18:39:41 +0100 [thread overview]
Message-ID: <20080131173941.GH25989@bingen.suse.de> (raw)
In-Reply-To: <alpine.LFD.1.00.0801311802150.9204@apollo.tec.linutronix.de>
On Thu, Jan 31, 2008 at 06:10:02PM +0100, Thomas Gleixner wrote:
> On Thu, 31 Jan 2008, Andi Kleen wrote:
>
> > On Thu, Jan 31, 2008 at 05:17:41PM +0100, Thomas Gleixner wrote:
> > > On Tue, 29 Jan 2008, Andi Kleen wrote:
> > > >
> > > > +static unsigned long direct_entry(unsigned long paddr)
> > >
> > > Please use a more sensible function name. This one has no association
> > > with the functionality at all.
> >
> > Can you suggest one? I honestly cannot think of a better one.
> > Its's a "entry" in the "direct" mapping.
>
> Doh, yes :) It just did not trigger.
I got rid of it now by switching over to the standard pte primitives
(with the usual casts). It's not prettier, but at least more consistent.
I hope i didn't break the paravirt case though, we'll see.
-Andi
prev parent reply other threads:[~2008-01-31 17:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-29 5:06 [PATCH] [0/9] Latest GBPAGES patchkit for 2.6.25 Andi Kleen
2008-01-29 5:06 ` [PATCH] [1/9] Handle kernel near memory hole in clear_kernel_mapping Andi Kleen
2008-01-31 15:48 ` Thomas Gleixner
2008-01-31 16:22 ` Andi Kleen
2008-01-29 5:06 ` [PATCH] [2/9] GBPAGES: Add feature macros for the gbpages cpuid bit Andi Kleen
2008-01-29 5:06 ` [PATCH] [3/9] GBPAGES: Split LARGE_PAGE_SIZE/MASK into PUD_PAGE_SIZE/PMD_PAGE_SIZE Andi Kleen
2008-01-31 15:57 ` Thomas Gleixner
2008-01-29 5:06 ` [PATCH] [4/9] Add pgtable accessor functions for GB pages Andi Kleen
2008-01-29 5:06 ` [PATCH] [5/9] GBPAGES: Support gbpages in pagetable dump Andi Kleen
2008-01-29 5:06 ` [PATCH] [6/9] GBPAGES: Add gbpages support to lookup_address Andi Kleen
2008-01-31 16:02 ` Thomas Gleixner
2008-01-29 5:06 ` [PATCH] [7/9] Add an option to disable direct mapping gbpages and a global variable Andi Kleen
2008-01-31 16:12 ` Thomas Gleixner
2008-01-31 16:24 ` Andi Kleen
2008-01-31 17:00 ` Thomas Gleixner
2008-01-29 5:06 ` [PATCH] [8/9] GBPAGES: Implement gbpages support in change_page_attr() Andi Kleen
2008-01-29 5:06 ` [PATCH] [9/9] GBPAGES: Do kernel direct mapping at boot using GB pages Andi Kleen
2008-01-31 16:17 ` Thomas Gleixner
2008-01-31 16:38 ` Andi Kleen
2008-01-31 17:10 ` Thomas Gleixner
2008-01-31 17:39 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080131173941.GH25989@bingen.suse.de \
--to=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox