public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Adrian Bunk <bunk@kernel.org>,
	tglx@linutronix.de, hpa@zytor.com, torvalds@linux-foundation.org,
	linux-kernel@vger.kernel.org
Subject: Re: x86: Why have __copy_from_user_ll_nocache* been exported?
Date: Thu, 31 Jan 2008 22:18:17 +0100	[thread overview]
Message-ID: <20080131211817.GA21210@elte.hu> (raw)
In-Reply-To: <20080131130529.b0e17815.akpm@linux-foundation.org>


* Andrew Morton <akpm@linux-foundation.org> wrote:

> > A commit that does nothing except for adding two unused 
> > EXPORT_SYMBOL's.
> > 
> > Without any rationale why they should be exported.
> 
> Don't look at me.  This has been sitting in my tree for nearly two 
> years as part of the reiser4 patchset.  It may not even be needed any 
> more.  I guess Ingo went on a fishing expedition and liked the change.

yes, i picked it up from -mm (as can be seen from the SOB line), and i 
agreed with that change regardless of the reiser4 patchset. (which might 
never see the light of upstream acceptance)

there's nothing more annoying than incomplete and inconsistent APIs. I'm 
trying to fix them up everywhere i see, and this is one of those cases. 
Adrian still has not given any rationale about why he wants to see the 
export removed.

	Ingo

  reply	other threads:[~2008-01-31 21:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-31 20:14 x86: Why have __copy_from_user_ll_nocache* been exported? Adrian Bunk
2008-01-31 20:31 ` Ingo Molnar
2008-02-01  9:50   ` Ingo Molnar
2008-01-31 21:05 ` Andrew Morton
2008-01-31 21:18   ` Ingo Molnar [this message]
2008-02-02 21:36   ` Adrian Bunk
2008-02-02 22:06     ` Andrew Morton
2008-02-04 19:58     ` Ingo Molnar
2008-02-10 22:16       ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080131211817.GA21210@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=bunk@kernel.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox