public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [Patch] include/asm-generic/tlb.h: fix a missing header
@ 2008-01-31 14:59 WANG Cong
  2008-01-31 22:08 ` Christoph Lameter
  0 siblings, 1 reply; 3+ messages in thread
From: WANG Cong @ 2008-01-31 14:59 UTC (permalink / raw)
  To: LKML; +Cc: Ingo Molnar, Christoph Lameter


This patch fixes this build error in current -git tree:

  CC      kernel/sched.o
In file included from include/asm/arch/tlb.h:10,
                 from include/asm/tlb.h:5,
                 from kernel/sched.c:71:
include/asm-generic/tlb.h: In function 'tlb_finish_mmu':
include/asm-generic/tlb.h:91: error: implicit declaration of function 'check_pgt_cache'
make[1]: *** [kernel/sched.o] Error 1
make: *** [kernel] Error 2


Cc: Ingo Molnar <mingo@elte.hu>
Cc: Christoph Lameter <clameter@sgi.com>
Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>

---

diff --git a/include/asm-generic/tlb.h b/include/asm-generic/tlb.h
index 6ce9f3a..4ebbe15 100644
--- a/include/asm-generic/tlb.h
+++ b/include/asm-generic/tlb.h
@@ -16,6 +16,7 @@
 #include <linux/swap.h>
 #include <linux/quicklist.h>
 #include <asm/tlbflush.h>
+#include <asm/pgalloc.h>
 
 /*
  * For UP we don't need to worry about TLB flush

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Patch] include/asm-generic/tlb.h: fix a missing header
  2008-01-31 14:59 [Patch] include/asm-generic/tlb.h: fix a missing header WANG Cong
@ 2008-01-31 22:08 ` Christoph Lameter
  2008-02-01  3:45   ` WANG Cong
  0 siblings, 1 reply; 3+ messages in thread
From: Christoph Lameter @ 2008-01-31 22:08 UTC (permalink / raw)
  To: WANG Cong; +Cc: LKML, Ingo Molnar

On Thu, 31 Jan 2008, WANG Cong wrote:

> index 6ce9f3a..4ebbe15 100644
> --- a/include/asm-generic/tlb.h
> +++ b/include/asm-generic/tlb.h
> @@ -16,6 +16,7 @@
>  #include <linux/swap.h>
>  #include <linux/quicklist.h>
>  #include <asm/tlbflush.h>
> +#include <asm/pgalloc.h>

Please also remove the #include <linux/quicklist.h>. It should have been 
part of 
a patch 
reversal.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Patch] include/asm-generic/tlb.h: fix a missing header
  2008-01-31 22:08 ` Christoph Lameter
@ 2008-02-01  3:45   ` WANG Cong
  0 siblings, 0 replies; 3+ messages in thread
From: WANG Cong @ 2008-02-01  3:45 UTC (permalink / raw)
  To: Christoph Lameter; +Cc: WANG Cong, LKML, Ingo Molnar

On Thu, Jan 31, 2008 at 02:08:31PM -0800, Christoph Lameter wrote:
>On Thu, 31 Jan 2008, WANG Cong wrote:
>
>> index 6ce9f3a..4ebbe15 100644
>> --- a/include/asm-generic/tlb.h
>> +++ b/include/asm-generic/tlb.h
>> @@ -16,6 +16,7 @@
>>  #include <linux/swap.h>
>>  #include <linux/quicklist.h>
>>  #include <asm/tlbflush.h>
>> +#include <asm/pgalloc.h>
>
>Please also remove the #include <linux/quicklist.h>. It should have been 
>part of 
>a patch 
>reversal.

Please ignore this patch, since Ingo already had the same one.

Thanks!


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-02-01  3:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-31 14:59 [Patch] include/asm-generic/tlb.h: fix a missing header WANG Cong
2008-01-31 22:08 ` Christoph Lameter
2008-02-01  3:45   ` WANG Cong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox