public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "George Spelvin" <linux@horizon.com>
To: hpa@zytor.com, ijc@hellion.org.uk
Cc: linux@horizon.com, linux-kernel@vger.kernel.org,
	tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com
Subject: There are smaller ways to encode a CRC32 table...
Date: Thu, 31 Jan 2008 23:53:20 -0500	[thread overview]
Message-ID: <20080201045320.11859.qmail@science.horizon.com> (raw)

The code to fill it in is smaller than the table itself.
Is it worth complicating things with some INIT code to reduce
the stored image size?  (The table is not compressible.)

#define CRC32POLY	0xedb88320	/* CRC32 polynomial, little-endian */

static uint32_t crctab32[256];

void
crc32init(void)
{
	unsigned i, j;
	uint32_t crc = 1;

	crctab32[0] = 0;

	for (i = 128; i; i >>= 1) {
		crc = (crc >> 1) ^ ((crc & 1) ? CRC32POLY : 0);
		for (j = 0; j < 256; j += 2*i)
			crctab32[i+j] = crc ^ crctab32[j];
	}
}

The above code basically computes the CRCs of the bytes 0x80, 0x40, ... 0x01,
and applies the identity crctab32[i^j] = crctab32[i] ^ crctab32[j].

And BTW, storing the inverse of the CRC only catches trailing (after the CRC)
all-zero padding.  If this is not a problem, it's not necessary, although you
still might want to do it just for consistency.  This inversion changes the
CRC of the entire image (body + CRC) from all-zero to a fixed non-zero value.
(To be precise, to the (non-inverted) CRC of 0xffffffff.)

             reply	other threads:[~2008-02-01  5:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-01  4:53 George Spelvin [this message]
2008-02-01  4:54 ` There are smaller ways to encode a CRC32 table H. Peter Anvin
2008-02-01 10:37 ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080201045320.11859.qmail@science.horizon.com \
    --to=linux@horizon.com \
    --cc=hpa@zytor.com \
    --cc=ijc@hellion.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox