From: Yinghai Lu <Yinghai.Lu@Sun.COM>
To: Andi Kleen <andi@firstfloor.org>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] make loglevel related commandline to early_param
Date: Fri, 01 Feb 2008 10:51:36 -0800 [thread overview]
Message-ID: <200802011051.36943.yinghai.lu@sun.com> (raw)
In-Reply-To: <p73bq704zqs.fsf@bingen.suse.de>
On Friday 01 February 2008 04:39:39 am Andi Kleen wrote:
> Yinghai Lu <Yinghai.Lu@Sun.COM> writes:
>
> > diff --git a/init/main.c b/init/main.c
> > index cb81ed1..a774a93 100644
> > --- a/init/main.c
> > +++ b/init/main.c
> > @@ -232,22 +232,18 @@ EXPORT_SYMBOL(loops_per_jiffy);
> >
> > static int __init debug_kernel(char *str)
> > {
> > - if (*str)
> > - return 0;
> > console_loglevel = 10;
> > return 1;
>
> The return semantics changes with early_param so you need to change that in all cases to return 0
> (and negative value for errors)
>
thanks. I will send another one.
YH
next prev parent reply other threads:[~2008-02-01 18:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-01 10:40 [PATCH] make loglevel related commandline to early_param Yinghai Lu
2008-02-01 12:39 ` Andi Kleen
2008-02-01 18:51 ` Yinghai Lu [this message]
2008-02-01 19:35 ` [PATCH] make loglevel related commandline to early_param v2 Yinghai Lu
2008-02-01 19:56 ` Andrew Morton
2008-02-01 20:21 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802011051.36943.yinghai.lu@sun.com \
--to=yinghai.lu@sun.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox