public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Takashi Iwai <tiwai@suse.de>
Cc: linux-kernel@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>
Subject: Re: [build bug] sound/drivers/opl3/opl3_synth.c
Date: Fri, 1 Feb 2008 12:05:52 +0100	[thread overview]
Message-ID: <20080201110552.GG27178@elte.hu> (raw)
In-Reply-To: <s5hmyql2c4q.wl%tiwai@suse.de>


* Takashi Iwai <tiwai@suse.de> wrote:

> > sound/drivers/opl3/opl3_synth.c: In function 'snd_opl3_find_patch':
> > sound/drivers/opl3/opl3_synth.c:308: error: 'OPL3_PATCH_HASH_SIZE' undeclared (first use in this function)
> > sound/drivers/opl3/opl3_synth.c:308: error: (Each undeclared identifier is reported only once
> > sound/drivers/opl3/opl3_synth.c:308: error: for each function it appears in.)
> > 
> > config attached.
> 
> Thanks.  Could you try the fix patch below?

i've added it to the queue. If you dont hear more from me today it means 
the fix works fine :)

Thanks for the quick fix - i had to temporarily turn off all of ALSA 
from the automated tester because sound/drivers/opl3/opl3_synth.c was 
unconditionally built in when ALSA was enabled. (which blew half a 
million lines of Linux sound code out from the scope of my testing - not 
good for test coverage)

	Ingo

  reply	other threads:[~2008-02-01 11:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-01 10:17 [build bug] sound/drivers/opl3/opl3_synth.c Ingo Molnar
2008-02-01 10:40 ` Takashi Iwai
2008-02-01 11:05   ` Ingo Molnar [this message]
2008-02-13 10:25     ` Ingo Molnar
2008-02-13 10:51       ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080201110552.GG27178@elte.hu \
    --to=mingo@elte.hu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox