Re: [Regression] 2.6.24-git3: Major annoyance during suspend/hibernation on x86-64 (bisected)

[Ingo Molnar <mingo@elte.hu>]

* Dmitry Adamushko <dmitry.adamushko@gmail.com> wrote:

> > I've observed delays from ~3 s. up to ~8 s. (out of ~20 tests) so 
> > the 10s. delay of msleep_interruptible() might be related but I'm 
> > still looking for the reason why this fix helps (and what goes wrong 
> > with the current code).
> 
> heh... it's pretty obvious indeed. What's msleep_interruptible() is 
> all about? :-)
> 
> "sleep waiting for signals"
> 
> so the 'watchdog' thread gets woken up
> 
> [ as a result of cpu_callback(action = CPU_DEAD) --> kthread_stop() ]
> 
> just to be immediately scheduled out again for as long as the
> remaining timeout > 0.
> 
> So it should work if we substitute msleep_interruptible() with 
> schedule_timeout_interruptible().

Doh. Could someone with ths problem please test the patch below, does it 
do the trick?

	Ingo

---
 kernel/softlockup.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux/kernel/softlockup.c
===================================================================
--- linux.orig/kernel/softlockup.c
+++ linux/kernel/softlockup.c
@@ -228,7 +228,7 @@ static int watchdog(void *__bind_cpu)
 	 */
 	while (!kthread_should_stop()) {
 		touch_softlockup_watchdog();
-		msleep_interruptible(10000);
+		schedule_timeout_interruptible(10*HZ);
 
 		if (this_cpu != check_cpu)
 			continue;