From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Sergei Shtylyov <sshtylyov@ru.mvista.com>,
Linux/m68k <linux-m68k@vger.kernel.org>,
Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Atari Falcon IDE: Add missing hwif variable
Date: Fri, 1 Feb 2008 22:49:17 +0100 [thread overview]
Message-ID: <200802012249.17952.bzolnier@gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0801271428390.9257@anakin>
On Sunday 27 January 2008, Geert Uytterhoeven wrote:
> Atari Falcon IDE: Add missing hwif variable
>
> Commit cbb010c180294a5242a7681555c28737d9dd26ab
>
> ide: drop 'initializing' argument from ide_register_hw()
>
> * Rename init_hwif_data() to ide_init_port_data() and export it.
>
> * For all users of ide_register_hw() with 'initializing' argument set
> hwif->present and hwif->hold are always zero so convert these host
> drivers to use ide_find_port()+ide_init_port_data()+ide_init_port_hw()
> instead (also no need for init_hwif_default() call since the setup
> done by it gets over-ridden by ide_init_port_hw() call).
>
> * Drop 'initializing' argument from ide_register_hw().
>
> introduced the usage of a hwif variable, but forgot to declare the actual
> variable.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>
applied, thanks
prev parent reply other threads:[~2008-02-01 22:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-27 13:29 [PATCH] Atari Falcon IDE: Add missing hwif variable Geert Uytterhoeven
2008-02-01 21:49 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802012249.17952.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox