From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760975AbYBAWhw (ORCPT ); Fri, 1 Feb 2008 17:37:52 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757125AbYBAWhK (ORCPT ); Fri, 1 Feb 2008 17:37:10 -0500 Received: from wa-out-1112.google.com ([209.85.146.182]:48828 "EHLO wa-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753202AbYBAWhD (ORCPT ); Fri, 1 Feb 2008 17:37:03 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to:mime-version:content-disposition:message-id:content-type:content-transfer-encoding; b=eq6vuOHjQf7wO1djF3t2ouFKkAno8xT0Ib9WClhiKS6iuD/u7j5w2ONoERpMkYpGGsar1FQ0WR3ZgQuNBUK7q/Rx6fewsIGIcwSh6TDWn161LUC9AJYfN7d35Gp6hDdid+oLZ2afZrznK7hEF2Vd5Mqg8QbWQFr+3iY58EnDi38= From: Bartlomiej Zolnierkiewicz To: Geert Uytterhoeven Subject: Re: [PATCH] Atari Falcon IDE: Add missing hwif variable Date: Fri, 1 Feb 2008 22:49:17 +0100 User-Agent: KMail/1.9.6 (enterprise 0.20071204.744707) Cc: Linus Torvalds , Andrew Morton , Sergei Shtylyov , Linux/m68k , Linux Kernel Development References: In-Reply-To: MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200802012249.17952.bzolnier@gmail.com> Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday 27 January 2008, Geert Uytterhoeven wrote: > Atari Falcon IDE: Add missing hwif variable > > Commit cbb010c180294a5242a7681555c28737d9dd26ab > > ide: drop 'initializing' argument from ide_register_hw() > > * Rename init_hwif_data() to ide_init_port_data() and export it. > > * For all users of ide_register_hw() with 'initializing' argument set > hwif->present and hwif->hold are always zero so convert these host > drivers to use ide_find_port()+ide_init_port_data()+ide_init_port_hw() > instead (also no need for init_hwif_default() call since the setup > done by it gets over-ridden by ide_init_port_hw() call). > > * Drop 'initializing' argument from ide_register_hw(). > > introduced the usage of a hwif variable, but forgot to declare the actual > variable. > > Signed-off-by: Geert Uytterhoeven > Cc: Bartlomiej Zolnierkiewicz > Cc: Sergei Shtylyov applied, thanks