Re: [PATCH 1 of 7] x86: convert pgalloc_64.h from macros to inlines

Ingo Molnar
2008-02-02T09:17:53Z

* Harvey Harrison <harvey.harrison@gmail.com> wrote:

> On Sat, 2008-02-02 at 01:05 -0800, Jeremy Fitzhardinge wrote:
> >
> > -#define __pte_free_tlb(tlb,pte) tlb_remove_page((tlb),(pte))
> > -
> > -#define __pmd_free_tlb(tlb,x) tlb_remove_page((tlb),virt_to_page(x))
> > -#define __pud_free_tlb(tlb,x) tlb_remove_page((tlb),virt_to_page(x))
> > +extern void __pte_free_tlb(struct mmu_gather *tlb, struct page *pte);
> > +extern void __pmd_free_tlb(struct mmu_gather *tlb, pmd_t *pmd);
> > +extern void __pud_free_tlb(struct mmu_gather *tlb, pud_t *pud);
>
> Small question: the extern isn't necessary in headers, is it preferred
> in linux anyway?

generally yes, to make it more visually separate from inlines, etc.

Ingo