Re: [PATCH 6 of 7] x86: move pud/pgd functions into common asm/pgalloc.h

Ingo Molnar
2008-02-02T10:41:19Z

* Jeremy Fitzhardinge <jeremy@goop.org> wrote:

>> i bisected it down to this patch of yours. It's a bit large so it's
>> not obvious what is happening. Could you please keep patches that do
>> functional changes smaller?
>
> Will do, though this one is more or less pure code motion. But I can
> make it actual pure code motion with a separate merge patch.

yes but the early hang is very real so either my hardware is stubbornly
ignoring that your patch is pure code movement (in which case i'll have
to have a word or two with my hardware), or your patch is perhaps wrong
somewhere ;-)

generally you can protect yourself against full reverts by separating
the NOP changes from the non-NOP changes. If a change is small enough i
might spot the bug immediately and fix it - otherwise i have to undo
your whole series to keep the x86.git ball rolling. I thought we went
through this excercise a few times already :-/ ...

Ingo