From: Olof Johansson <olof@lixom.net>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
torvalds@linux-foundation.org, git-commits-head@vger.kernel.org,
gregkh@suse.de
Subject: Re: [PATCH] Fix fallout from PCI: PCIE ASPM support
Date: Sat, 2 Feb 2008 09:39:08 -0600 [thread overview]
Message-ID: <20080202153908.GA16753@lixom.net> (raw)
In-Reply-To: <47A406B9.5070609@zytor.com>
On Fri, Feb 01, 2008 at 09:59:21PM -0800, H. Peter Anvin wrote:
> Olof Johansson wrote:
>> On Sat, Feb 02, 2008 at 05:06:42AM +0000, Linux Kernel Mailing List wrote:
>>
>>> PCI: PCIE ASPM support
>>
>> This one broke almost all defconfigs on powerpc, since they enable
>> CONFIG_EXPERIMENTAL and CONFIG_PCI, and this option defaults to y.
>>
>> Make it default to 'n' like most other options, and make it depend on
>> ACPI. Take out the unneccessary default 'n' from the debug option as well.
>>
>
> Is this actually ACPI-dependent?
It shouldn't be, but it seems like it's currently entangled a bit with
the acpi include files. OSC_ACTIVE_STATE_PWR_SUPPORT comes from
linux/pci-acpi.h.
I can't include acpi/acpi_bus.h though, since that ends up pulling in
asm/ files that don't exist on powerpc.
So if the probing is fixed, no, it's not ACPI-dependent. Seems like
something that's just as well to mask behind it until someone's actually
used and tested it on a non-ACPI platform though, no?
I would experiment with it but I believe our firmware turns off empty
links before the kernel is booted, we don't support hotplug at this time.
-Olof
next prev parent reply other threads:[~2008-02-02 15:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200802020506.m1256gXG027547@hera.kernel.org>
2008-02-02 5:26 ` [PATCH] Fix fallout from PCI: PCIE ASPM support Olof Johansson
2008-02-02 5:59 ` H. Peter Anvin
2008-02-02 15:39 ` Olof Johansson [this message]
2008-02-02 20:04 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080202153908.GA16753@lixom.net \
--to=olof@lixom.net \
--cc=git-commits-head@vger.kernel.org \
--cc=gregkh@suse.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox