From: Greg KH <gregkh@suse.de>
To: Ingo Molnar <mingo@elte.hu>
Cc: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz,
pcihpd-discuss@lists.sourceforge.net
Subject: Re: [patch] pci: pci_enable_device_bars() fix (was: [GIT PATCH] PCI patches for 2.6.24)
Date: Sat, 2 Feb 2008 10:44:41 -0800 [thread overview]
Message-ID: <20080202184441.GA12301@suse.de> (raw)
In-Reply-To: <20080202111322.GA30767@elte.hu>
On Sat, Feb 02, 2008 at 12:13:22PM +0100, Ingo Molnar wrote:
>
> * Greg KH <gregkh@suse.de> wrote:
>
> > PCI: Remove users of pci_enable_device_bars()
> > PCI: Remove pci_enable_device_bars()
>
> simple allyesconfig testing found a build failure due to last night's
> PCI merge, on 32-bit x86:
>
> drivers/scsi/lpfc/lpfc_init.c: In function 'lpfc_pci_probe_one':
> drivers/scsi/lpfc/lpfc_init.c:1897: error: implicit declaration of function 'pci_enable_device_bars'
>
> fix attached.
>
> ( This call has been introduced upstream 3 weeks ago by commit
> 8a4df120b07, but the PCI tree has apparently not been fully re-tested
> with Linus-latest since that point. )
Wait, my testing caught this. I made the change to the patch myself,
adding the needed conversion to my tree, it's here, on my disk!
Oh crap, I never checked it in.
/me goes off to sulk in shame.
Very sorry about this, totally my fault, I knew this needed to be fixed,
fixed it, but it didn't propogate to the tree to send to Linus.
I suck. I need a vacation and an empty inbox.
I'll be sending fixup patches for this and other merge messes in a few
hours, once the coffee has kicked in...
greg k-h
next prev parent reply other threads:[~2008-02-02 18:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-01 23:11 [GIT PATCH] PCI patches for 2.6.24 Greg KH
2008-02-02 0:42 ` Andrew Morton
2008-02-02 0:49 ` Greg KH
2008-02-02 1:07 ` Andrew Morton
2008-02-02 11:13 ` [patch] pci: pci_enable_device_bars() fix (was: [GIT PATCH] PCI patches for 2.6.24) Ingo Molnar
2008-02-02 15:51 ` [patch] pci: pci_enable_device_bars() fix Jeff Garzik
2008-02-02 16:01 ` James Bottomley
2008-02-02 17:08 ` Ingo Molnar
2008-02-02 17:33 ` Jeff Garzik
2008-02-02 17:57 ` Ingo Molnar
2008-02-02 18:49 ` Jeff Garzik
2008-02-02 19:35 ` Ingo Molnar
2008-02-02 20:48 ` Jeff Garzik
2008-02-04 12:57 ` Ingo Molnar
2008-02-04 13:12 ` Andrew Morton
2008-02-04 15:32 ` Jeff Garzik
2008-02-04 15:30 ` Jeff Garzik
2008-02-02 18:08 ` James Bottomley
2008-02-02 19:00 ` Ingo Molnar
2008-02-02 18:44 ` Greg KH [this message]
2008-02-02 19:05 ` [patch] pci: pci_enable_device_bars() fix (was: [GIT PATCH] PCI patches for 2.6.24) Ingo Molnar
2008-02-02 20:56 ` [patch] pci: pci_enable_device_bars() fix Jeff Garzik
2008-02-02 23:23 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080202184441.GA12301@suse.de \
--to=gregkh@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=mingo@elte.hu \
--cc=pcihpd-discuss@lists.sourceforge.net \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox