From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andi Kleen <ak@suse.de>, "H. Peter Anvin" <hpa@zytor.com>,
LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: [RFC] x86: setup code_bytes - use mask to restrict it's size
Date: Sun, 3 Feb 2008 01:12:11 +0300 [thread overview]
Message-ID: <20080202221211.GA6749@cvg> (raw)
This patch strips off 8 bytes from text section. Not a really
big advantage (especially for __init section). It seems 8192
bytes of disassembled code is rare used anyway.
before:
text data bss dec hex filename
9900 176 20 10096 2770 arch/x86/kernel/traps_64.o.old
after:
text data bss dec hex filename
9892 176 20 10088 2768 arch/x86/kernel/traps_64.o
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
---
If there is no benefit at all - just drop the patch.
Any comments are welcome ;)
Index: linux-2.6.git/arch/x86/kernel/traps_32.c
===================================================================
--- linux-2.6.git.orig/arch/x86/kernel/traps_32.c 2008-02-02 23:52:16.000000000 +0300
+++ linux-2.6.git/arch/x86/kernel/traps_32.c 2008-02-03 00:39:58.000000000 +0300
@@ -1229,8 +1229,9 @@ __setup("kstack=", kstack_setup);
static int __init code_bytes_setup(char *s)
{
code_bytes = simple_strtoul(s, NULL, 0);
- if (code_bytes > 8192)
- code_bytes = 8192;
+
+ /* we don't want too long code-dump */
+ code_bytes &= 8191;
return 1;
}
Index: linux-2.6.git/arch/x86/kernel/traps_64.c
===================================================================
--- linux-2.6.git.orig/arch/x86/kernel/traps_64.c 2008-02-02 23:52:16.000000000 +0300
+++ linux-2.6.git/arch/x86/kernel/traps_64.c 2008-02-03 00:38:10.000000000 +0300
@@ -1196,8 +1196,9 @@ early_param("kstack", kstack_setup);
static int __init code_bytes_setup(char *s)
{
code_bytes = simple_strtoul(s, NULL, 0);
- if (code_bytes > 8192)
- code_bytes = 8192;
+
+ /* we don't want too long code-dump */
+ code_bytes &= 8191;
return 1;
}
next reply other threads:[~2008-02-02 22:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-02 22:12 Cyrill Gorcunov [this message]
2008-02-02 22:25 ` [RFC] x86: setup code_bytes - use mask to restrict it's size H. Peter Anvin
2008-02-02 22:32 ` Cyrill Gorcunov
2008-02-02 22:59 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080202221211.GA6749@cvg \
--to=gorcunov@gmail.com \
--cc=ak@suse.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox