From: Frank Seidel <frank@f-seidel.de>
To: Rabin Vincent <rabin@rab.in>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Remove unneeded code in sys_getpriority
Date: Sun, 3 Feb 2008 10:54:45 +0100 [thread overview]
Message-ID: <200802031054.45604.frank@f-seidel.de> (raw)
In-Reply-To: <20080203030429.GB7459@ubuntu>
On Sunday 03 February 2008 04:04, Rabin Vincent wrote:
> This check is not required because the condition is always true.
> ...
> - if (niceval > retval)
> - retval = niceval;
> + retval = 20 - task_nice(p);
Thats surely correct, but on the other hand currently those
case blocks are quite independet of their possition/could easily
be rearranged now .. or think of another case is put ahead.
Then this could mess up things.
Thanks,
Frank
next prev parent reply other threads:[~2008-02-03 9:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-03 3:04 [PATCH] Remove unneeded code in sys_getpriority Rabin Vincent
2008-02-03 9:54 ` Frank Seidel [this message]
2008-02-03 17:58 ` Rabin Vincent
2008-02-03 18:10 ` Frank Seidel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802031054.45604.frank@f-seidel.de \
--to=frank@f-seidel.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rabin@rab.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox