From: Nick Piggin <npiggin@suse.de>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: "Siddha, Suresh B" <suresh.b.siddha@intel.com>,
linux-kernel@vger.kernel.org, arjan@linux.intel.com,
mingo@elte.hu, ak@suse.de, jens.axboe@oracle.com,
James.Bottomley@steeleye.com, andrea@suse.de, clameter@sgi.com,
akpm@linux-foundation.org, andrew.vasquez@qlogic.com,
willy@linux.intel.com, Zach Brown <zach.brown@oracle.com>
Subject: Re: [rfc] direct IO submission and completion scalability issues
Date: Sun, 3 Feb 2008 12:58:01 +0100 [thread overview]
Message-ID: <20080203115801.GA22650@wotan.suse.de> (raw)
In-Reply-To: <84144f020802030253y596ca557w3a44a8601a13596d@mail.gmail.com>
On Sun, Feb 03, 2008 at 12:53:02PM +0200, Pekka Enberg wrote:
> Hi Nick,
>
> On Feb 3, 2008 11:52 AM, Nick Piggin <npiggin@suse.de> wrote:
> > +asmlinkage void smp_call_function_fast_interrupt(void)
> > +{
>
> [snip]
>
> > + while (!list_empty(&list)) {
> > + struct call_single_data *data;
> > +
> > + data = list_entry(list.next, struct call_single_data, list);
> > + list_del(&data->list);
> > +
> > + data->func(data->info);
> > + if (data->wait) {
> > + smp_mb();
> > + data->wait = 0;
>
> Why do we need smp_mb() here (maybe add a comment to keep
> Andrew/checkpatch happy)?
Yeah, definitely... it's just a really basic RFC, but I should get
into the habit of just doing it anyway.
Thanks,
Nick
next prev parent reply other threads:[~2008-02-03 11:58 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-28 1:21 [rfc] direct IO submission and completion scalability issues Siddha, Suresh B
2007-07-30 18:20 ` Christoph Lameter
2007-07-30 20:35 ` Siddha, Suresh B
2007-07-31 4:19 ` Nick Piggin
2007-07-31 17:14 ` Siddha, Suresh B
2007-08-01 0:41 ` Nick Piggin
2007-08-01 0:55 ` Siddha, Suresh B
2007-08-01 1:24 ` Nick Piggin
2008-02-03 9:52 ` Nick Piggin
2008-02-03 10:53 ` Pekka Enberg
2008-02-03 11:58 ` Nick Piggin [this message]
2008-02-04 2:10 ` David Chinner
2008-02-04 4:14 ` Arjan van de Ven
2008-02-04 4:40 ` David Chinner
2008-02-04 10:09 ` Nick Piggin
2008-02-05 0:14 ` David Chinner
2008-02-08 7:50 ` Nick Piggin
2008-02-04 18:21 ` Zach Brown
2008-02-04 20:10 ` Jens Axboe
2008-02-04 21:45 ` Arjan van de Ven
2008-02-05 8:24 ` Jens Axboe
2008-02-04 10:12 ` Jens Axboe
2008-02-04 10:31 ` Nick Piggin
2008-02-04 10:33 ` Jens Axboe
2008-02-04 22:28 ` James Bottomley
2008-02-04 10:30 ` Andi Kleen
2008-02-04 21:47 ` Siddha, Suresh B
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080203115801.GA22650@wotan.suse.de \
--to=npiggin@suse.de \
--cc=James.Bottomley@steeleye.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=andrea@suse.de \
--cc=andrew.vasquez@qlogic.com \
--cc=arjan@linux.intel.com \
--cc=clameter@sgi.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=penberg@cs.helsinki.fi \
--cc=suresh.b.siddha@intel.com \
--cc=willy@linux.intel.com \
--cc=zach.brown@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox