public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Haavard Skinnemoen <hskinnemoen@atmel.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: linux-kernel@vger.kernel.org, davem@davemloft.net,
	bryan.wu@analog.com, dhowells@redhat.com,
	Cyrill Gorcunov <gorcunov@gmail.com>
Subject: Re: [patch 1/4] AVR32: cleanup - use _AC macro to define PAGE_SIZE
Date: Sun, 3 Feb 2008 14:25:06 +0100	[thread overview]
Message-ID: <20080203142506.2003e5cf@siona> (raw)
In-Reply-To: <47a5a660.19e7300a.0584.329a@mx.google.com>

[removed bogus @atmel.co address from Cc]

On Sun, 03 Feb 2008 14:22:18 +0300
Cyrill Gorcunov <gorcunov@gmail.com> wrote:

> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>

Applied, thanks.

I found myself having to grep through include/linux to figure out what
this _AC macro was really all about, so I added this to the description:

    PAGE_SIZE is used both from assembly and C code. We want to have type
    specifiers when using it from C, but this will make the assembler
    confused, so we need to make it conditional.
    
    This is exactly what the _AC macro is for, so using it allows us to
    get rid of a few lines of cpp noise.

My first thought was "Autoconf", and it sent shivers down my spine ;-)

Haavard

  reply	other threads:[~2008-02-03 13:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20080203112217.126814108@gmail.com>
2008-02-03 11:22 ` [patch 1/4] AVR32: cleanup - use _AC macro to define PAGE_SIZE Cyrill Gorcunov
2008-02-03 13:25   ` Haavard Skinnemoen [this message]
2008-02-03 14:04     ` Cyrill Gorcunov
2008-02-03 11:22 ` [patch 2/4] BLACKFIN: " Cyrill Gorcunov
2008-02-03 11:22 ` [patch 3/4] FRV: " Cyrill Gorcunov
2008-02-03 11:22 ` [patch 4/4] SPARC: " Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080203142506.2003e5cf@siona \
    --to=hskinnemoen@atmel.com \
    --cc=bryan.wu@analog.com \
    --cc=davem@davemloft.net \
    --cc=dhowells@redhat.com \
    --cc=gorcunov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox