From: Dale Farnsworth <dale@farnsworth.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lockdep: Include all lock classes in all_lock_classes
Date: Sun, 3 Feb 2008 12:47:56 -0700 [thread overview]
Message-ID: <20080203194756.GA28783@farnsworth.org> (raw)
In-Reply-To: <1202052062.32654.69.camel@lappy>
On Sun, Feb 03, 2008 at 04:21:02PM +0100, Peter Zijlstra wrote:
> On Fri, 2008-02-01 at 08:21 -0700, Dale Farnsworth wrote:
> > Add each lock class to the all_lock_classes list when it is
> > first registered.
> >
> > Previously, lock classes were added to all_lock_classes when
> > the lock class was first used.
>
> > Since one of the uses of the list is to find unused locks, this didn't
> > work well.
>
> You mean in lockdep_proc.c to generate the statistics?
Yes, that's where I noticed it. On my platform, there was one
unused lock which was missed.
>
> Another potential issue might be count_matching_names() generating a
> wrong class version.
I haven't looked into that issue yet.
-Dale
next prev parent reply other threads:[~2008-02-03 19:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-01 15:21 [PATCH] lockdep: Include all lock classes in all_lock_classes Dale Farnsworth
2008-02-03 15:21 ` Peter Zijlstra
2008-02-03 19:47 ` Dale Farnsworth [this message]
2008-02-03 19:57 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080203194756.GA28783@farnsworth.org \
--to=dale@farnsworth.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox