From: Andi Kleen <andi@firstfloor.org>
To: Nick Piggin <npiggin@suse.de>
Cc: "Siddha, Suresh B" <suresh.b.siddha@intel.com>,
linux-kernel@vger.kernel.org, arjan@linux.intel.com,
mingo@elte.hu, ak@suse.de, jens.axboe@oracle.com,
James.Bottomley@SteelEye.com, andrea@suse.de, clameter@sgi.com,
akpm@linux-foundation.org, andrew.vasquez@qlogic.com,
willy@linux.intel.com, Zach Brown <zach.brown@oracle.com>
Subject: Re: [rfc] direct IO submission and completion scalability issues
Date: Mon, 4 Feb 2008 11:30:01 +0100 [thread overview]
Message-ID: <20080204103001.GA2674@basil.nowhere.org> (raw)
In-Reply-To: <20080203095252.GA11043@wotan.suse.de>
> + q = &__get_cpu_var(call_single_queue);
> + spin_lock_irqsave(&q->lock, flags);
> + list_replace_init(&q->list, &list);
> + spin_unlock_irqrestore(&q->lock, flags);
I think you could do that lockless if you use a similar data structure
as netchannels (essentially a fixed size single buffer queue with atomic
exchange of the first/last pointers) and not using a list. That would avoid
at least one bounce for the lock and likely another one for the list
manipulation.
Also the right way would be to not add a second mechanism for this,
but fix the standard smp_call_function_single() to support it.
-Andi
next prev parent reply other threads:[~2008-02-04 10:30 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-28 1:21 [rfc] direct IO submission and completion scalability issues Siddha, Suresh B
2007-07-30 18:20 ` Christoph Lameter
2007-07-30 20:35 ` Siddha, Suresh B
2007-07-31 4:19 ` Nick Piggin
2007-07-31 17:14 ` Siddha, Suresh B
2007-08-01 0:41 ` Nick Piggin
2007-08-01 0:55 ` Siddha, Suresh B
2007-08-01 1:24 ` Nick Piggin
2008-02-03 9:52 ` Nick Piggin
2008-02-03 10:53 ` Pekka Enberg
2008-02-03 11:58 ` Nick Piggin
2008-02-04 2:10 ` David Chinner
2008-02-04 4:14 ` Arjan van de Ven
2008-02-04 4:40 ` David Chinner
2008-02-04 10:09 ` Nick Piggin
2008-02-05 0:14 ` David Chinner
2008-02-08 7:50 ` Nick Piggin
2008-02-04 18:21 ` Zach Brown
2008-02-04 20:10 ` Jens Axboe
2008-02-04 21:45 ` Arjan van de Ven
2008-02-05 8:24 ` Jens Axboe
2008-02-04 10:12 ` Jens Axboe
2008-02-04 10:31 ` Nick Piggin
2008-02-04 10:33 ` Jens Axboe
2008-02-04 22:28 ` James Bottomley
2008-02-04 10:30 ` Andi Kleen [this message]
2008-02-04 21:47 ` Siddha, Suresh B
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080204103001.GA2674@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=James.Bottomley@SteelEye.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=andrea@suse.de \
--cc=andrew.vasquez@qlogic.com \
--cc=arjan@linux.intel.com \
--cc=clameter@sgi.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=npiggin@suse.de \
--cc=suresh.b.siddha@intel.com \
--cc=willy@linux.intel.com \
--cc=zach.brown@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox