Re: [2.6 patch] x86: allow 64bit setting in Kconfig

[Adrian Bunk <bunk@kernel.org>]

On Fri, Feb 01, 2008 at 04:22:27PM +0100, Ingo Molnar wrote:
> 
> * Adrian Bunk <bunk@kernel.org> wrote:
> 
> >  # Select 32 or 64 bit
> >  config 64BIT
> > -	bool "64-bit kernel" if ARCH = "x86"
> > +	bool "64-bit kernel"
> >  	default ARCH = "x86_64"
> 
> NACK. You have just broken:
> 
>     make ARCH=i386 randconfig
> 
> on a 64-bit box that has a 32-bit .config in its kernel directory.
> 
> The randconfig/allyesconfig/allnoconfig variants override whatever is in 
> the current .config. Making the result depend on whatever is in the 
> .config at the moment is fundamentally wrong.
> 
> "oldconfig" on the other hand has correct sensitivity to the existing 
> .config - and that always worked correctly. So if you pop a 32-bit or a 
> 64-bit .config into a kernel tree, that will be listened to, no matter 
> whether you are on a 32-bit or on a 64-bit host.

Do you have ARCH=x86 set in your environment, the command line or 
patched into your Makefile when this works for you?

> 	Ingo

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed