From: Andrew Morton <akpm@linux-foundation.org>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Alexey Dobriyan <adobriyan@sw.ru>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Whine about suspicious return values from module's ->init() hook
Date: Mon, 4 Feb 2008 22:24:57 -0800 [thread overview]
Message-ID: <20080204222457.286b962f.akpm@linux-foundation.org> (raw)
In-Reply-To: <200802051708.37349.rusty@rustcorp.com.au>
On Tue, 5 Feb 2008 17:08:37 +1100 Rusty Russell <rusty@rustcorp.com.au> wrote:
> On Tuesday 05 February 2008 14:53:18 Andrew Morton wrote:
> > On Tue, 5 Feb 2008 14:43:31 +1100 Rusty Russell <rusty@rustcorp.com.au>
> wrote:
> > > On Tuesday 05 February 2008 02:42:15 Alexey Dobriyan wrote:
> > > > One head-scratching session could be noticeably shorter with this
> > > > patch...
> > > >
> > > > Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>
> > >
> > > If we want to prevent > 0 returns, let's just BUG_ON().
> >
> > That risks killing previously-working setups. WARN_ON is sufficient.
>
> I disagree. WARN_ON is useful for developers, but they can handle BUG_ON,
> too.
For developers, BUG_ON has zero benefit relative to WARN_ON.
For non-developers, BUG_ON has large disadvantages relative to WARN_ON.
It's a no-brainer.
next prev parent reply other threads:[~2008-02-05 6:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-04 15:42 [PATCH] Whine about suspicious return values from module's ->init() hook Alexey Dobriyan
2008-02-04 21:15 ` Andrew Morton
2008-02-05 3:43 ` Rusty Russell
2008-02-05 3:53 ` Andrew Morton
2008-02-05 6:08 ` Rusty Russell
2008-02-05 6:24 ` Andrew Morton [this message]
2008-02-05 22:48 ` Rusty Russell
2008-02-05 23:37 ` Andrew Morton
2008-02-06 6:55 ` Rusty Russell
2008-02-10 22:09 ` [PATCH v2] " Alexey Dobriyan
2008-03-04 3:24 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080204222457.286b962f.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adobriyan@sw.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox