Re: 2.6.24-mm1: module params broken

Andrew Morton
2008-02-05T00:17:12Z

On Tue, 5 Feb 2008 00:06:39 +0000 (GMT)
Hugh Dickins <hugh@veritas.com> wrote:

> On Mon, 4 Feb 2008, Andrew Morton wrote:
> >
> > Takashi found a bug in it:
>
> Bless him.
>
> > --- a/lib/vsprintf.c~add-new-string-functions-strict_strto-and-convert-kernel-params-to-use-them-fix-2
> > +++ a/lib/vsprintf.c
> > @@ -234,7 +234,7 @@ int strict_strto##type(const char *cp, u
> > if (ret != 0) \
> > *res = -(*res); \
> > } else \
> > - ret = strict_strtou##type(cp+1, base, res); \
> > + ret = strict_strtou##type(cp, base, res); \
> > \
> > return ret; \
> > } \
> > _
> >
> > and I was very bad and didn't immediately prepare and upload the fix and
> > hence probably wasted a lot of your time, for which I apologise. In my
> > defense, it was 4:00AM Sunday and I had lost eye control by then.
>
> Please don't even begin to think of apologizing to me:
> that's so much the wrong way round it's embarrassing.

three minutes saved here led to maybe an hour lost there.

> It's scary to think of how much of your time gets wasted
> on knocking these -mms into some kind of shape that's
> then ready for the rest of us to start attacking them.

Well yeah. Three minutes saved there (* 1000) led to maybe 1000 hours lost
here. Kernel economics :(

> > Does that fix fix it? If not: patch overboard.
>
> Reprieve! Indeed that precisely fixes it: numerous
> modules now working again with that fix. Thanks a lot.

Thanks.