From: Andi Kleen <ak@suse.de>
To: Mel Gorman <mel@csn.ul.ie>
Cc: tglx@linutronix.de, mingo@elte.hu, linux-kernel@vger.kernel.org,
apw@shadowen.org
Subject: Re: [PATCH] [1/2] Move NUMAQ io handling into arch/x86/pci/numa.c
Date: Wed, 6 Feb 2008 09:15:00 +0100 [thread overview]
Message-ID: <200802060915.01121.ak@suse.de> (raw)
In-Reply-To: <20080205222603.GB4207@csn.ul.ie>
> > +#define XQUAD_PORTIO_BASE 0xfe400000
>
> There is still a definition in include/asm-x86/io_32.h . Is this
> intentional?
Probably not.
>
> > +extern void *xquad_portio; /* Where the IO area was mapped */
>
> Does the extern need to be here when you've added it (minus the comment)
> to mach_apic.h later in the patch?
The extern was intended to be removed, but somehow that change didn't make
it into the final patch. Doesn't matter much either way though.
> Fix for "x86: move NUMAQ io handling into arch/x86/pci/numa.c"
>
> The intention of commit c7e844f0415252c7e1a2153a97e7a0c511d61ada was to
> replace a number of outl_quad() calls with a writel() equivilant. One of
> the changes was not equivilant. This patch corrects it.
Yes looks good; thanks.
-Andi
prev parent reply other threads:[~2008-02-06 8:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-01 17:08 [PATCH] [1/2] Move NUMAQ io handling into arch/x86/pci/numa.c Andi Kleen
2008-02-01 17:08 ` [PATCH] [2/2] Remove NUMAQ support in io_32.h Andi Kleen
2008-02-01 17:21 ` Ingo Molnar
2008-02-01 17:21 ` [PATCH] [1/2] Move NUMAQ io handling into arch/x86/pci/numa.c Ingo Molnar
2008-02-05 22:26 ` Mel Gorman
2008-02-06 8:15 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802060915.01121.ak@suse.de \
--to=ak@suse.de \
--cc=apw@shadowen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mel@csn.ul.ie \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox