Re: [PATCH] reduce large do_mount stack usage with noinlines

Andrew Morton
2008-02-06T23:23:28Z

On Wed, 06 Feb 2008 17:11:38 -0600
Eric Sandeen <sandeen@redhat.com> wrote:

> /*
> * recursively change the type of the mountpoint.
> + * noinline this do_mount helper to save do_mount stack space.
> */
> -static int do_change_type(struct nameidata *nd, int flag)
> +static noinline int do_change_type(struct nameidata *nd, int flag)

What we could do here is defined a new noinline_because_of_stack_suckiness
and use that. Reasons:

- self-documenting, so we don't need to comment each site

- can be made a no-op for suitable __GNUC__ values if gcc ever fixes this

- our children we can go through and delete them all when nobody is using
the offending gcc versions any more.

what thinkest thou?