From: Len Brown <lenb@kernel.org>
To: Roel Kluin <12o3l@tiscali.nl>
Cc: corentincj@iksaif.net, acpi4asus-user@lists.sourceforge.net,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [drivers/misc/asus-laptop.c] add parentheses
Date: Thu, 7 Feb 2008 00:42:29 -0500 [thread overview]
Message-ID: <200802070042.29667.lenb@kernel.org> (raw)
In-Reply-To: <47A4CD8A.7060604@tiscali.nl>
applied.
thanks,
-Len
On Saturday 02 February 2008 15:07, Roel Kluin wrote:
> '!' has a higher priority than '&': bitanding has no effect.
>
> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
> ---
> diff --git a/drivers/misc/asus-laptop.c b/drivers/misc/asus-laptop.c
> index 7dce318..65c67d1 100644
> --- a/drivers/misc/asus-laptop.c
> +++ b/drivers/misc/asus-laptop.c
> @@ -322,7 +322,7 @@ static void write_status(acpi_handle handle, int out, int mask)
>
> switch (mask) {
> case MLED_ON:
> - out = !out & 0x1;
> + out = !(out & 0x1);
> break;
> case GLED_ON:
> out = (out & 0x1) + 1;
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
prev parent reply other threads:[~2008-02-07 5:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-02 20:07 [PATCH] [drivers/misc/asus-laptop.c] add parentheses Roel Kluin
2008-02-07 5:42 ` Len Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802070042.29667.lenb@kernel.org \
--to=lenb@kernel.org \
--cc=12o3l@tiscali.nl \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=corentincj@iksaif.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox