Re: [PATCH 2/8] Add interface for queuing work on a specific CPU

Harvey Harrison
2008-02-07T17:54:43Z

On Thu, 2008-02-07 at 10:49 +0100, Jens Axboe wrote:
> On Thu, Feb 07 2008, Andrew Morton wrote:
> > On Thu, 7 Feb 2008 10:18:59 +0100 Jens Axboe <jens.axboe@oracle.com> wrote:
> >
> > > Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
> > > ---
> > > include/linux/workqueue.h | 1 +
> > > kernel/workqueue.c | 15 +++++++++++++++
> > > 2 files changed, 16 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/include/linux/workqueue.h b/include/linux/workqueue.h
> > > index 7f28c32..4c46944 100644
> > > --- a/include/linux/workqueue.h
> > > +++ b/include/linux/workqueue.h
> > > @@ -179,6 +179,7 @@ __create_workqueue_key(const char *name, int singlethread,
> > > extern void destroy_workqueue(struct workqueue_struct *wq);
> > >
> > > extern int FASTCALL(queue_work(struct workqueue_struct *wq, struct work_struct *work));
> > > +extern int FASTCALL(queue_work_on_cpu(struct workqueue_struct *wq, struct work_struct *work, int cpu));
> >
> > -ETOOWIDE
> >
> > please don't add fastcall - we're trying to remove it.
>
> Oops yes, I'll kill the fastcall and fix the > 80 char line!
>

I'll be making another round-up patch at -rc1 for FASTCALL/fastcall

FYI

Harvey