From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759651AbYBGE22 (ORCPT ); Wed, 6 Feb 2008 23:28:28 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755561AbYBGE2S (ORCPT ); Wed, 6 Feb 2008 23:28:18 -0500 Received: from koto.vergenet.net ([210.128.90.7]:34137 "EHLO koto.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755490AbYBGE2R (ORCPT ); Wed, 6 Feb 2008 23:28:17 -0500 Date: Thu, 7 Feb 2008 13:28:09 +0900 From: Simon Horman To: Sven Wegener Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ipvs: Make the synchronization interval controllable Message-ID: <20080207042808.GA6211@verge.net.au> References: <1202342263-25176-1-git-send-email-sven.wegener@stealer.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1202342263-25176-1-git-send-email-sven.wegener@stealer.net> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 07, 2008 at 12:57:43AM +0100, Sven Wegener wrote: > The default synchronization interval of 1000 milliseconds is too high for a > heavily loaded director. Collecting the connection information from one second > and then sending it out in a burst will overflow the socket buffer and lead to > synchronization information being dropped. Make the interval controllable by a > sysctl variable so that users can tune it. We enforce a lower limit of 0 and an > upper limit of 2000 ms on the interval. A too large interval can make the > synchronization buffer consume too much memory and will also delay the exit of > the kernel threads. > > Signed-off-by: Sven Wegener Hi Sven, I have no problems with the spirit of this patch, and the range checking seems good to me. Though I wonder if 2000 might not be an exessively low maximum. I can't think of a usage case off-hand, but I'm not sure I understand why a user shouldn't be able to set it to much (rediculously) higher values. In any case, thats not a big deal. Acked-by: Simon Horman > --- > > Changes from the last version include the addition of the range enforcement. > Also place the definitions of the variables where all other ipvs sysctl > variables are. -- Horms