From: "Uwe Kleine-König" <Uwe.Kleine-Koenig@digi.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Kristoffer Ericson <kristoffer.ericson@gmail.com>,
rpurdie@openedhand.com,
Linux-arm <linux-arm-kernel@lists.arm.linux.org.uk>,
linux-main <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH/HP7XX] - Add combined LCD / BL driver for platform HP Jornada 7xx handhelds
Date: Thu, 7 Feb 2008 08:19:42 +0100 [thread overview]
Message-ID: <20080207071942.GC5235@digi.com> (raw)
In-Reply-To: <20080206194557.GF32245@flint.arm.linux.org.uk>
Hello Russell,
> > Doh, right. Do you use a different checkpatch? I mean it doesn't react on
> > that for me.
>
> No, all of the comments I've given were spotted by merely reading the patch.
May I ask how you spot tab vs. 8 space problems? Do you apply the patch
and check in an editor?
Best regards
Uwe
--
Uwe Kleine-König, Software Engineer
Digi International GmbH Branch Breisach, Küferstrasse 8, 79206 Breisach, Germany
Tax: 315/5781/0242 / VAT: DE153662976 / Reg. Amtsgericht Dortmund HRB 13962
next prev parent reply other threads:[~2008-02-07 7:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-05 18:53 [PATCH/HP7XX] - Add combined LCD / BL driver for platform HP Jornada 7xx handhelds Kristoffer Ericson
2008-02-06 12:34 ` Roel Kluin
2008-02-06 12:38 ` Roel Kluin
2008-02-06 16:33 ` Kristoffer Ericson
2008-02-06 16:44 ` Russell King - ARM Linux
2008-02-06 19:21 ` Kristoffer Ericson
2008-02-06 19:31 ` Russell King - ARM Linux
2008-02-06 19:43 ` Kristoffer Ericson
2008-02-06 19:45 ` Russell King - ARM Linux
2008-02-07 7:19 ` Uwe Kleine-König [this message]
2008-02-06 19:49 ` Kristoffer Ericson
2008-02-06 17:04 ` Roel Kluin
2008-02-06 17:22 ` Sam Ravnborg
2008-02-06 17:25 ` Richard Purdie
2008-02-06 16:26 ` Kristoffer Ericson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080207071942.GC5235@digi.com \
--to=uwe.kleine-koenig@digi.com \
--cc=kristoffer.ericson@gmail.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rpurdie@openedhand.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox