From: Andrew Morton <akpm@linux-foundation.org>
To: Jan Kara <jack@suse.cz>
Cc: linux-kernel@vger.kernel.org, Michael Tokarev <mjt@tls.msk.ru>,
stable@kernel.org
Subject: Re: [PATCH] quota: Turn quotas off when remounting read-only
Date: Thu, 7 Feb 2008 10:36:55 -0800 [thread overview]
Message-ID: <20080207103655.14ce8512.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080207143721.GH6140@duck.suse.cz>
On Thu, 7 Feb 2008 15:37:21 +0100 Jan Kara <jack@suse.cz> wrote:
> Turn off quotas before filesystem is remounted read only. Otherwise quota will
> try to write to read-only filesystem which does no good... We could also just
> refuse to remount ro when quota is enabled but turning quota off is consistent
> with what we do on umount.
>
> Signed-off-by: Jan Kara <jack@suse.cz>
> ---
> Andrew, this should fix the hang reported... Please apply. Thanks.
>
> diff --git a/fs/super.c b/fs/super.c
> index ceaf2e3..945c322 100644
> --- a/fs/super.c
> +++ b/fs/super.c
> @@ -603,6 +603,7 @@ int do_remount_sb(struct super_block *sb, int flags, void *data, int force)
> mark_files_ro(sb);
> else if (!fs_may_remount_ro(sb))
> return -EBUSY;
> + DQUOT_OFF(sb);
> }
>
> if (sb->s_op->remount_fs) {
Cool. And this is applicable to 2.6.23, 2.6.22 and even earlier, isn't it?
next prev parent reply other threads:[~2008-02-07 18:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-07 14:37 [PATCH] quota: Turn quotas off when remounting read-only Jan Kara
2008-02-07 18:36 ` Andrew Morton [this message]
2008-02-07 19:27 ` Michael Tokarev
2008-02-11 12:39 ` Jan Kara
2008-02-15 14:10 ` Jan Engelhardt
2008-02-15 14:21 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080207103655.14ce8512.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mjt@tls.msk.ru \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox