From: Ingo Molnar <mingo@elte.hu>
To: Andi Kleen <andi@firstfloor.org>
Cc: Yinghai Lu <Yinghai.Lu@Sun.COM>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86_64: fix page table size
Date: Thu, 7 Feb 2008 12:54:42 +0100 [thread overview]
Message-ID: <20080207115442.GB387@elte.hu> (raw)
In-Reply-To: <p73wsph2pry.fsf@bingen.suse.de>
* Andi Kleen <andi@firstfloor.org> wrote:
> Yinghai Lu <Yinghai.Lu@Sun.COM> writes:
> >
> > diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
> > index eb376b5..31f0e82 100644
> > --- a/arch/x86/mm/init_64.c
> > +++ b/arch/x86/mm/init_64.c
> > @@ -370,7 +370,7 @@ static void __init find_early_table_space(unsigned long end)
> >
> > puds = (end + PUD_SIZE - 1) >> PUD_SHIFT;
> > tables = round_up(puds * sizeof(pud_t), PAGE_SIZE);
> > - if (direct_gbpages) {
> > + if (!direct_gbpages) {
>
> What tree did you use? The patch I submitted had
>
> if (direct_gbpages == GBP_ON) {
yes, the bug was introduced in your original submission of gbpages.
Ingo
next prev parent reply other threads:[~2008-02-07 11:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-06 20:46 my config doesnt compile in your tree Yinghai Lu
2008-02-06 21:53 ` Ingo Molnar
2008-02-06 23:01 ` Yinghai Lu
[not found] ` <20080206231226.GA6417@elte.hu>
2008-02-07 4:22 ` [PATCH] x86_64: fix page table size Yinghai Lu
2008-02-07 4:23 ` [PATCH] x86_64: clean up find_e820_area Yinghai Lu
2008-02-07 8:12 ` Ingo Molnar
2008-02-07 7:23 ` [PATCH] x86_64: fix page table size Andi Kleen
2008-02-07 11:54 ` Ingo Molnar [this message]
2008-02-07 17:28 ` Andi Kleen
2008-02-07 8:09 ` Ingo Molnar
2008-02-07 8:36 ` Yinghai Lu
2008-02-07 8:49 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080207115442.GB387@elte.hu \
--to=mingo@elte.hu \
--cc=Yinghai.Lu@Sun.COM \
--cc=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox