From: "Siddha, Suresh B" <suresh.b.siddha@intel.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Arjan van de Ven <arjan@linux.intel.com>,
"Siddha, Suresh B" <suresh.b.siddha@intel.com>,
tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: issue with patch "x86: no CPA on iounmap"
Date: Thu, 7 Feb 2008 12:02:52 -0800 [thread overview]
Message-ID: <20080207200251.GA21564@linux-os.sc.intel.com> (raw)
In-Reply-To: <20080205070535.GA10695@elte.hu>
On Tue, Feb 05, 2008 at 08:05:35AM +0100, Ingo Molnar wrote:
> there are many GART drivers, and the method used depends on the GART
> driver. The following GART drivers still use ioremap in one way or
> another:
There is another issue I see in the recent pageattr changes, again in the GART
driver context.
GART drivers use map_page_into_agp() and unmap_page_from_agp() during
runtime (and not just during load and unload of the driver module). In the
recent pageattr changes, we seem to have dropped the concept of reverting
to the large page(for the kernel identity mapping) while changing the attribute
back to WB. In this GART driver context, over the time, potentially
kernel identity mappings might be backed by small pages, if we don't
revert to large page again during set_memory_wb() which gets called during
unmap_page_from_agp() for a RAM page. And thus loosing the advantage of large
page mapping for kernel identity mappings.
thanks,
suresh
prev parent reply other threads:[~2008-02-07 20:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-05 1:13 issue with patch "x86: no CPA on iounmap" Siddha, Suresh B
2008-02-05 4:41 ` Arjan van de Ven
2008-02-05 4:48 ` Arjan van de Ven
2008-02-05 7:05 ` Ingo Molnar
2008-02-05 7:14 ` Arjan van de Ven
2008-02-07 20:02 ` Siddha, Suresh B [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080207200251.GA21564@linux-os.sc.intel.com \
--to=suresh.b.siddha@intel.com \
--cc=arjan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox