From: Pavel Machek <pavel@ucw.cz>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
kernel list <linux-kernel@vger.kernel.org>,
Linux-pm mailing list <linux-pm@lists.osdl.org>
Subject: Re: [rft] s2ram wakeup moves to .c, could fix few machines
Date: Thu, 7 Feb 2008 23:49:08 +0100 [thread overview]
Message-ID: <20080207224908.GD6096@elf.ucw.cz> (raw)
In-Reply-To: <47AB8A0F.9@zytor.com>
On Thu 2008-02-07 14:45:35, H. Peter Anvin wrote:
> Rafael J. Wysocki wrote:
>
>> ENTRY(wakeup_long64)
>> wakeup_long64:
>> - movq saved_magic, %rax
>> - movq $0x123456789abcdef0, %rdx
>> - cmpq %rdx, %rax
>> - jne bogus_64_magic
>> + movq saved_magic, %rax
>> + movq $0x123456789abcdef0, %rdx
>> + cmpq %rdx, %rax
>> + jne bogus_64_magic
>
> A random magic is probably more likely to be unique than something like
> that.
This is already "unlikely enough", I'd say. It does not look like a
pointer, and it is long enough.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2008-02-07 22:49 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-05 19:06 [rft] s2ram wakeup moves to .c, could fix few machines Pavel Machek
2008-02-06 1:27 ` Rafael J. Wysocki
2008-02-06 1:36 ` H. Peter Anvin
2008-02-06 1:42 ` Rafael J. Wysocki
2008-02-06 1:51 ` H. Peter Anvin
2008-02-06 1:56 ` Rafael J. Wysocki
2008-02-06 11:29 ` Pavel Machek
2008-02-14 2:54 ` Bill Davidsen
2008-02-06 23:48 ` Rafael J. Wysocki
2008-02-07 22:12 ` Rafael J. Wysocki
2008-02-07 22:28 ` Sam Ravnborg
2008-02-07 22:34 ` H. Peter Anvin
2008-02-08 21:31 ` Pavel Machek
2008-02-08 21:34 ` Pavel Machek
2008-02-08 21:41 ` Pavel Machek
2008-02-08 21:47 ` Sam Ravnborg
2008-02-08 21:49 ` Pavel Machek
2008-02-07 22:28 ` Pavel Machek
2008-02-07 22:40 ` Rafael J. Wysocki
2008-02-07 22:44 ` H. Peter Anvin
2008-02-07 22:53 ` Rafael J. Wysocki
2008-02-07 22:45 ` H. Peter Anvin
2008-02-07 22:49 ` Pavel Machek [this message]
2008-02-08 21:13 ` Pavel Machek
2008-02-08 21:41 ` Maxim Levitsky
2008-02-08 21:51 ` Pavel Machek
2008-02-07 22:46 ` H. Peter Anvin
2008-02-07 22:51 ` Pavel Machek
2008-02-07 23:09 ` Rafael J. Wysocki
2008-02-07 22:57 ` Rafael J. Wysocki
2008-02-07 23:14 ` H. Peter Anvin
2008-02-08 21:35 ` Pavel Machek
2008-02-07 22:38 ` H. Peter Anvin
2008-02-07 23:06 ` Rafael J. Wysocki
2008-02-07 23:13 ` H. Peter Anvin
2008-02-07 23:35 ` Pavel Machek
2008-02-07 23:36 ` Rafael J. Wysocki
2008-02-07 23:41 ` Pavel Machek
2008-02-07 23:42 ` H. Peter Anvin
2008-02-08 7:04 ` Pavel Machek
2008-02-08 7:40 ` H. Peter Anvin
2008-02-08 16:23 ` Rafael J. Wysocki
2008-02-08 21:00 ` Pavel Machek
2008-02-08 21:02 ` H. Peter Anvin
2008-02-08 21:09 ` Pavel Machek
2008-02-08 21:18 ` H. Peter Anvin
2008-02-08 21:20 ` [linux-pm] " Alan Stern
2008-02-08 21:23 ` Pavel Machek
2008-02-08 21:27 ` H. Peter Anvin
2008-02-08 21:31 ` Pavel Machek
2008-02-08 21:56 ` Rafael J. Wysocki
2008-02-08 21:59 ` Pavel Machek
2008-02-08 21:56 ` Pavel Machek
2008-02-08 21:58 ` Pavel Machek
2008-02-08 22:01 ` Rafael J. Wysocki
2008-02-08 22:08 ` Pavel Machek
2008-02-09 0:18 ` Rafael J. Wysocki
2008-02-09 0:32 ` H. Peter Anvin
2008-02-09 13:48 ` Rafael J. Wysocki
2008-02-10 21:14 ` Pavel Machek
2008-02-10 21:21 ` Sam Ravnborg
2008-02-06 23:37 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080207224908.GD6096@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.osdl.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox