From: Jens Axboe <jens.axboe@oracle.com>
To: Jerome Marchand <jmarchan@redhat.com>
Cc: linux-kernel@vger.kernel.org, "Ed L. Cashin" <ecashin@coraid.com>
Subject: Re: [Patch 1/6] Enhanced partition statistics: core statistics
Date: Fri, 8 Feb 2008 11:06:49 +0100 [thread overview]
Message-ID: <20080208100649.GH15220@kernel.dk> (raw)
In-Reply-To: <47A36174.7040600@redhat.com>
On Fri, Feb 01 2008, Jerome Marchand wrote:
> This patch contain the core infrastructure of enhanced partition
> statistics. It adds to struct hd_struct the same stats data as struct
> gendisk and define basics function to manipulate them.
>
> Signed-off-by: Jerome Marchand <jmarchan@redhat.com>
> ---
> include/linux/genhd.h | 132 +++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 131 insertions(+), 1 deletion(-)
> diff -uprN -X linux-2.6/Documentation/dontdiff linux-2.6.orig/include/linux/genhd.h linux-2.6/include/linux/genhd.h
> --- linux-2.6.orig/include/linux/genhd.h 2008-01-31 16:43:28.000000000 +0100
> +++ linux-2.6/include/linux/genhd.h 2008-01-31 16:47:12.000000000 +0100
> @@ -101,6 +101,13 @@ struct hd_struct {
> #ifdef CONFIG_FAIL_MAKE_REQUEST
> int make_it_fail;
> #endif
> + unsigned long stamp;
> + int in_flight;
> +#ifdef CONFIG_SMP
> + struct disk_stats *dkstats;
> +#else
> + struct disk_stats dkstats;
> +#endif
> };
This wont work on !CONFIG_SMP, since the disk_stats structure definition
is below that point. I moved it up.
Committed 1-6, thanks. But please remember to test UP configs too :)
--
Jens Axboe
prev parent reply other threads:[~2008-02-08 10:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-01 18:14 [Patch 1/6] Enhanced partition statistics: core statistics Jerome Marchand
2008-02-08 10:06 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080208100649.GH15220@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=ecashin@coraid.com \
--cc=jmarchan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox