Re: [PATCH] arch/arm/Kconfig: Make UIO available on ARM architecture

Sam Ravnborg
2008-02-07T21:19:41Z

On Thu, Feb 07, 2008 at 08:29:40PM +0000, Russell King - ARM Linux wrote:
> On Thu, Feb 07, 2008 at 09:23:29PM +0100, Sam Ravnborg wrote:
> > +# if PCMCIA is selected then we need IDE
> > +config ARM_PCMCIA
> > + depends on PCMCIA
>
> Shouldn't this be:
>
> def_bool PCMCIA
yes - thanks.

>
> ?
>
> > + select HAVE_IDE
>
> Also, should this be something ARM specific - if you have PCMCIA you could
> have a CF card plugged in, so... There's nothing ARM specific about that.

So we can replace the above with this:
diff --git a/drivers/pcmcia/Kconfig b/drivers/pcmcia/Kconfig
index 519b4ff..8b22281 100644
--- a/drivers/pcmcia/Kconfig
+++ b/drivers/pcmcia/Kconfig
@@ -38,6 +38,7 @@ config PCMCIA_DEBUG
config PCMCIA
tristate "16-bit PCMCIA support"
select CRC32
+ select HAVE_IDE
default y
---help---
This option enables support for 16-bit PCMCIA cards. Most older

Makes sense.

>
> > +
> > +# select MTD except in a few corner configuration cases
> > +config ARM_MTD
> > + depends on ALIGNMENT_TRAP || !CPU_CP15_MMU
>
> Ditto.
Yes.

Sam