[patch] [git pull] Input updates for 2.6.25-rc0

Randy Dunlap
2008-02-08T23:39:45Z

On Fri, 8 Feb 2008 15:28:12 -0800 Stephen Hemminger wrote:

> On Sat, 9 Feb 2008 00:25:36 +0100
> Ingo Molnar <mingo@elte.hu> wrote:
>
> >
> > * Dmitry Torokhov <dtor@insightbb.com> wrote:
> >
> > > Stephen Hemminger (2):
> > > Input: add driver for Fujitsu application buttons
> >
> > this change broke the build on x86 in randconfig testing:
> >
> > drivers/built-in.o: In function `apanel_detach_client':
> > apanel.c:(.text+0x15c120): undefined reference to `__led_classdev_unregister'
> > drivers/built-in.o: In function `apanel_probe':
> > apanel.c:(.text+0x15c30f): undefined reference to `led_classdev_register'
> >
> > .config attached.
> >
> > the Kconfig dependencies seem incomplete:
> >
> > > +config INPUT_APANEL
> > > + tristate "Fujitsu Lifebook Application Panel buttons"
> > > + depends on X86
> > > + select I2C_I801
> > > + select INPUT_POLLDEV
> > > + select CHECK_SIGNATURE
> > > + help
> >
> > it doesnt list LEDS.
> >
> > Ingo
>
> I think someone already sent a patch to select the LEDS

I did... and more. Who will merge it? (below)

---
From: Randy Dunlap <randy.dunlap@oracle.com>

Add I2C to config since the driver makes several i2c*() calls.

Add to help text that the Intel I2C ICH (i801) driver is also needed
for this kernel.

Add LEDS_CLASS to config since the driver makes les_classdev_*() calls:
ERROR: "led_classdev_register" [drivers/input/misc/apanel.ko] undefined!
ERROR: "__led_classdev_unregister" [drivers/input/misc/apanel.ko] undefined!

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/input/misc/Kconfig | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

--- linux-2.6.24-mm1.orig/drivers/input/misc/Kconfig
+++ linux-2.6.24-mm1/drivers/input/misc/Kconfig
@@ -42,14 +42,14 @@ config INPUT_M68K_BEEP

config INPUT_APANEL
tristate "Fujitsu Lifebook Application Panel buttons"
- depends on X86
- select I2C_I801
+ depends on X86 && I2C && LEDS_CLASS
select INPUT_POLLDEV
select CHECK_SIGNATURE
help
Say Y here for support of the Application Panel buttons, used on
Fujitsu Lifebook. These are attached to the mainboard through
- an SMBus interface managed by the I2C Intel ICH (i801) driver.
+ an SMBus interface managed by the I2C Intel ICH (i801) driver,
+ which you should also build for this kernel.

To compile this driver as a module, choose M here: the module will
be called apanel.