From: Ingo Molnar <mingo@elte.hu>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Harvey Harrison <harvey.harrison@gmail.com>,
viro@ZenIV.linux.org.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix sparse warning from include/linux/mmzone.h
Date: Fri, 8 Feb 2008 23:26:37 +0100 [thread overview]
Message-ID: <20080208222637.GA2989@elte.hu> (raw)
In-Reply-To: <alpine.LFD.1.00.0802081401410.2896@woody.linux-foundation.org>
* Linus Torvalds <torvalds@linux-foundation.org> wrote:
> Heh, yeah. That's a very odd way to write it.
>
> It would probably make more sense to just write it as something like
>
> struct zone *base = zone->zone_pgdat->node_zones;
>
> if (zone == base + ZONE_HIGHMEM ||
> (zone == base + ZONE_MOVABLE && zone_movable_is_highmem());
>
> instead.
missing closing parenthesis ;-)
btw., doesnt this look even nicer?:
if (zone == base + ZONE_HIGHMEM ||
(zone == base + ZONE_MOVABLE && zone_movable_is_highmem()));
[ i guess it must be Friday... ;-) ]
Ingo
next prev parent reply other threads:[~2008-02-08 22:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-07 20:52 [PATCH] fix sparse warning from include/linux/mmzone.h Harvey Harrison
2008-02-08 21:51 ` Andrew Morton
2008-02-08 22:04 ` Linus Torvalds
2008-02-08 22:17 ` Harvey Harrison
2008-02-08 22:26 ` Ingo Molnar [this message]
2008-02-08 22:35 ` Linus Torvalds
2008-02-13 19:56 ` Harvey Harrison
2008-02-13 20:36 ` [PATCH] remove sparse warning for mmzone.h Harvey Harrison
2008-02-08 22:38 ` [PATCH] fix sparse warning from include/linux/mmzone.h Harvey Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080208222637.GA2989@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox