From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: Adrian Bunk <adrian.bunk@movial.fi>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: scsi/arm/fas216.c compile error
Date: Sun, 10 Feb 2008 13:52:49 +0000 [thread overview]
Message-ID: <20080210135249.GA25703@flint.arm.linux.org.uk> (raw)
In-Reply-To: <47AEF6FD.8080801@panasas.com>
On Sun, Feb 10, 2008 at 03:07:09PM +0200, Boaz Harrosh wrote:
> On Sat, Feb 09 2008 at 2:04 +0200, Adrian Bunk <adrian.bunk@movial.fi> wrote:
> > Commit 30b0c37b27485a9cb897bfe3824f6f517b8c80d6 causes the following
> > compile error:
> >
> > <-- snip -->
> >
> > ...
> > CC drivers/scsi/arm/fas216.o
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/scsi/arm/fas216.c: In function 'fas216_std_done':
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/scsi/arm/fas216.c:2120: error: 'struct scsi_cmnd' has no member named 'request_bufflen'
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/scsi/arm/fas216.c:2122: error: 'struct scsi_cmnd' has no member named 'use_sg'
> > make[4]: *** [drivers/scsi/arm/fas216.o] Error 1
> >
> > <-- snip -->
> >
> > cu
> > Adrian
> >
> It's in mainline 84ac86ca8c6787f9efff28bc04b1b65fe0a5c310
> [SCSI] arm: convert to accessors and !use_sg cleanup
>
> Thanks for checking. This patch was in scsi-pending tree since forever, And we were unable
> to get a responsive maintainer to ACK on them. until the breakage cause went into mainline
> we finally managed a Tested-by:.
>
> I guess sometimes people are so busy, you need a bulldozer to shove 20 minutes into they're
> schedule.
Oh, just 20 minutes in your opinion? Reality works at a different tick
rate to your timing then.
However, if you're seeing a bulid error, it means that the *WRONG* patch
went in. No idea why I even bothered to test it if that's what happens.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next prev parent reply other threads:[~2008-02-10 13:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-09 0:04 scsi/arm/fas216.c compile error Adrian Bunk
2008-02-10 13:07 ` Boaz Harrosh
2008-02-10 13:52 ` Russell King [this message]
2008-02-10 13:58 ` Russell King
2008-02-10 14:15 ` Boaz Harrosh
2008-02-10 14:20 ` James Bottomley
2008-02-10 14:37 ` Boaz Harrosh
2008-02-10 22:02 ` Russell King
2008-02-10 22:44 ` James Bottomley
2008-02-11 9:47 ` Boaz Harrosh
2008-02-11 10:02 ` Russell King
2008-02-11 10:14 ` Boaz Harrosh
2008-02-10 13:59 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080210135249.GA25703@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=James.Bottomley@HansenPartnership.com \
--cc=adrian.bunk@movial.fi \
--cc=bharrosh@panasas.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox