From: Ingo Molnar <mingo@elte.hu>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Ray Lee <ray-lk@madrabbit.org>, Sam Ravnborg <sam@ravnborg.org>,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@zip.com.au>,
Thomas Gleixner <tglx@linutronix.de>,
Jason Wessel <jason.wessel@windriver.com>
Subject: Re: [git pull] kgdb light, v5
Date: Sun, 10 Feb 2008 20:34:55 +0100 [thread overview]
Message-ID: <20080210193455.GA18067@elte.hu> (raw)
In-Reply-To: <47AF483E.10905@web.de>
* Jan Kiszka <jan.kiszka@web.de> wrote:
> [This still runs fine here, but sharp eyes are always welcome!]
>
> Cleanup of the way kgdb
> - accesses unsafe memory via probe_kernel_*
> - converts to/from hex representation
> - passes errors due to such accesses around
>
> At this chance I also fix kgdb_ebin2mem, which was broken /wrt escape
> sequence handling.
great! Applied. The kgdb memory accesses look _much_ cleaner now, and
it's a significant simplification as well:
2 files changed, 109 insertions(+), 244 deletions(-)
the uaccess.h macros look a bit ugly now (it all got inherited from the
existing [and ancient] probe_kernel_address() macro) and because we now
touch it materially anyway, we might as well do it right?
Ingo
next prev parent reply other threads:[~2008-02-10 19:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-10 7:13 [0/6] kgdb light Ingo Molnar
2008-02-10 7:37 ` David Miller
2008-02-10 10:47 ` Sam Ravnborg
2008-02-10 13:25 ` Jan Kiszka
2008-02-10 19:31 ` Sam Ravnborg
2008-02-10 20:23 ` Jan Kiszka
2008-02-10 21:16 ` Ingo Molnar
2008-02-10 21:30 ` Sam Ravnborg
2008-02-10 21:34 ` Ingo Molnar
2008-02-10 16:36 ` [git pull] kgdb light, v5 Ingo Molnar
2008-02-10 17:30 ` Ray Lee
2008-02-10 17:39 ` Jan Kiszka
2008-02-10 18:59 ` Ray Lee
2008-02-10 18:53 ` Jan Kiszka
2008-02-10 19:34 ` Ingo Molnar [this message]
2008-02-10 19:44 ` Linus Torvalds
2008-02-10 20:19 ` Ingo Molnar
2008-02-10 20:22 ` Jan Kiszka
2008-02-10 21:13 ` Ingo Molnar
2008-02-10 20:29 ` Ingo Molnar
2008-02-10 20:41 ` Ingo Molnar
2008-02-10 19:34 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080210193455.GA18067@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@zip.com.au \
--cc=jan.kiszka@web.de \
--cc=jason.wessel@windriver.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ray-lk@madrabbit.org \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox