Re: [PATCH] [1/8] CPA: Fix gbpages support in try_preserve_lage_page

Thomas Gleixner
2008-02-11T09:45:51Z

On Mon, 11 Feb 2008, Andi Kleen wrote:

>
> Use correct page sizes and masks for GB pages in try_preserve_large_page()
>
> This prevents a boot hang on a GB capable system with CONFIG_DIRECT_GBPAGES
> enabled.

Doh, yes. Applied.

Thanks,
tglx

> Signed-off-by: Andi Kleen <ak@suse.de>
>
> ---
> arch/x86/mm/pageattr.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: linux/arch/x86/mm/pageattr.c
> ===================================================================
> --- linux.orig/arch/x86/mm/pageattr.c
> +++ linux/arch/x86/mm/pageattr.c
> @@ -278,8 +278,8 @@ try_preserve_large_page(pte_t *kpte, uns
> break;
> #ifdef CONFIG_X86_64
> case PG_LEVEL_1G:
> - psize = PMD_PAGE_SIZE;
> - pmask = PMD_PAGE_MASK;
> + psize = PUD_PAGE_SIZE;
> + pmask = PUD_PAGE_MASK;
> break;
> #endif
> default:
>