Re: [PATCH] [3/8] CPA: Test the correct mapping alias on x86-64

Ingo Molnar
2008-02-11T11:49:36Z

* Andi Kleen <ak@suse.de> wrote:

> static_protections previously would test against the x86-64 kernel
> mapping twice. First against the unchanged symbol directly from the
> linker (which always points into the kernel mapping) and then again it
> would manually relocate the address into the kernel mapping and test
> again.
>
> This patch reverses the second test instead to test against the direct
> mapping (low) aliases virtual addresses which was probably intended in
> the first place.
>
> Simply use __pa and __va for that.

thanks, applied.

( the practical implications of this are low because we do not utilize
the low direct aliases for execution. It needs to be fixed
nevertheless (will be needed for PAT later on anyway) and your cleanup
and #ifdef reduction is nice to have as well. )

Ingo