Re: [PATCH] proc: extend /proc/<pid>/fdinfo/<fd>

[Eugene Teo <eugeneteo@kernel.sg>]

Hi Motohiro-san,

<quote sender="KOSAKI Motohiro">
> In general, I think this patch isn't wrong idea.
> but it shuld be brush up more, may be.

Thanks.

> > kerndev: ~/code/kernel# cat /proc/`pgrep pickup`/fdinfo/6
> > mode:   0622
> 
> I think this is inode attribute, but not fd attribute.

Yes, it is an inode attribute.

> > dev:    253,0
> > ino:    21463057
> 
> may be useful, agreed with you :)

Thanks.

> > uid:    89
> > gid:    89
> > rdev:   0,0
> > pos:    0
> > flags:  04002 FD_CLOEXEC # if close-on-exec flag is set
> 
> agreed with Miklos's opinion.
> 
> > path:   /var/spool/postfix/public/pickup
> 
> may be, we shold think namespace..

Besides readlink, this info can be gathered by running:
ls -laF /proc/<pid>/fd/<fd>

So, I agree with Miklo's opinion that we can omit this in the output.

> > You can also use this to find out more information about locked open files:
> 
> is your requirement only fd -> ino pick up?

Not only this, but it is useful to know quickly if the open file descriptor
has a close-on-exec flag set.

Thanks,
Eugene