Re: [PATCH] forcedeth: seperate handler for msix and normal int.

Jeff Garzik
2008-02-11T15:37:25Z

Yinghai Lu wrote:
> [PATCH] forcedeth: seperate handler for msix and normal int.
>
> so we don't need to keep checking np->msi_flags to see if NV_MSI_X_ENABLED is set in
> handler
>
> Signed-off-by: Yinghai Lu <yinghai.lu@sun.com>

Two comments:

* can you regenerate this on top of 2.6.25-rc1?

* take a look at the 'fe' branch of
git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git

and see what you think about the work in there. We need to get cleanups
like that (and more) upstream. It also intersects with Tom @ Google's
"Reduce locking in TX path" patch.

Jeff