From: Olof Johansson <olof@lixom.net>
To: Mike Galbraith <efault@gmx.de>
Cc: Willy Tarreau <w@1wt.eu>,
linux-kernel@vger.kernel.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: Scheduler(?) regression from 2.6.22 to 2.6.24 for short-lived threads
Date: Mon, 11 Feb 2008 14:31:59 -0600 [thread overview]
Message-ID: <20080211203159.GA11161@lixom.net> (raw)
In-Reply-To: <1202759926.4165.31.camel@homer.simson.net>
On Mon, Feb 11, 2008 at 08:58:46PM +0100, Mike Galbraith wrote:
>
> On Mon, 2008-02-11 at 11:26 -0600, Olof Johansson wrote:
> > On Mon, Feb 11, 2008 at 09:15:55AM +0100, Mike Galbraith wrote:
> > > Piddling around with your testcase, it still looks to me like things
> > > improved considerably in latest greatest git. Hopefully that means
> > > happiness is in the pipe for the real workload... synthetic load is
> > > definitely happier here as burst is shortened.
> >
> > The real workload doesn't see much of an improvement. The changes I did
> > when tinkering yesterday seem like they're better at modelling just
> > what's going on with that one.
>
> So the real application is trying to yield? If so, you could try
> prodding /proc/sys/kernel/sched_compat_yield.
The real application wasn't using yield, but it also didn't get hung up
on the busy-wait loop, that was a mistake by me on Friday. Practically
all the time of that application was spent in the actual workload
loop. I tried adding a yield at the bottom loop, but it didn't make a
significant difference.
> It shouldn't matter if you yield or not really, that should reduce the
> number of non-work spin cycles wasted awaiting preemption as threads
> execute in series (the problem), and should improve your performance
> numbers, but not beyond single threaded.
>
> If I plugged a yield into the busy wait, I would expect to see a large
> behavioral difference due to yield implementation changes, but that
> would only be a symptom in this case, no? Yield should be a noop.
Exactly. It made a big impact on the first testcase from Friday, where
the spin-off thread spent the bulk of the time in the busy-wait loop,
with a very small initial workload loop. Thus the yield passed the cpu
over to the other thread who got a chance to run the small workload,
followed by a quick finish by both of them. The better model spends the
bulk of the time in the first workload loop, so yielding doesn't gain
at all the same amount.
I still added it to rule out that it was a factor in the time
differences.
-Olof
next prev parent reply other threads:[~2008-02-11 20:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-09 0:04 Scheduler(?) regression from 2.6.22 to 2.6.24 for short-lived threads Olof Johansson
2008-02-09 0:08 ` Ingo Molnar
2008-02-09 0:32 ` Olof Johansson
2008-02-09 7:58 ` Mike Galbraith
2008-02-09 8:03 ` Willy Tarreau
2008-02-09 10:58 ` Mike Galbraith
2008-02-09 11:40 ` Willy Tarreau
2008-02-09 13:37 ` Mike Galbraith
2008-02-09 16:19 ` Willy Tarreau
2008-02-09 17:33 ` Mike Galbraith
2008-02-10 5:29 ` Olof Johansson
2008-02-10 6:15 ` Willy Tarreau
2008-02-10 7:00 ` Olof Johansson
2008-02-10 7:58 ` Willy Tarreau
2008-02-11 8:15 ` Mike Galbraith
2008-02-11 17:26 ` Olof Johansson
2008-02-11 19:58 ` Mike Galbraith
2008-02-11 20:31 ` Olof Johansson [this message]
2008-02-12 9:23 ` Mike Galbraith
2008-02-13 5:49 ` Mike Galbraith
2008-02-11 21:45 ` Bill Davidsen
2008-02-12 4:30 ` Mike Galbraith
[not found] <fa.6N2dhyJ1cmBqiuFKgCaYfwduM+0@ifi.uio.no>
2008-02-09 1:49 ` Robert Hancock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080211203159.GA11161@lixom.net \
--to=olof@lixom.net \
--cc=a.p.zijlstra@chello.nl \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox