From: Jeff Dike <jdike@addtoit.com>
To: Christoph Lameter <clameter@sgi.com>
Cc: Matt Mackall <mpm@selenic.com>,
Pekka J Enberg <penberg@cs.helsinki.fi>,
blaisorblade@yahoo.it, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] slob: fix linking for user mode linux
Date: Mon, 11 Feb 2008 18:32:24 -0500 [thread overview]
Message-ID: <20080211233224.GA11432@c2.user-mode-linux.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0802111443130.28253@schroedinger.engr.sgi.com>
On Mon, Feb 11, 2008 at 02:44:21PM -0800, Christoph Lameter wrote:
> UML defined its own external __kmalloc and things. Isnt there some other
> way to fix it? I guess including slab.h is not possible here?
This is definitely dubious code on my part and I wouldn't support
Pekka's patch unless you're going to uninline __kmalloc for some
other reason.
The reason for this is that part of UML is userspace code, and thus
can't use kernel headers. However, they do need some kernel
interfaces in some form. That form has traditionally been little
wrappers in the kernel side of UML which just call the kernel
interface.
In this case, there used to be um_kmalloc, which just called kmalloc.
I've been trying to get rid of these stupid little helpers for a
while, and this is what I ended up with for kmalloc.
It would be an annoyance to reintroduce um_kmalloc, but that might be
the best thing to do here.
Jeff
--
Work email - jdike at linux dot intel dot com
next prev parent reply other threads:[~2008-02-11 23:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-11 22:32 [PATCH] slob: fix linking for user mode linux Pekka J Enberg
2008-02-11 22:39 ` Matt Mackall
2008-02-11 22:44 ` Christoph Lameter
2008-02-11 23:32 ` Jeff Dike [this message]
2008-02-12 6:23 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080211233224.GA11432@c2.user-mode-linux.org \
--to=jdike@addtoit.com \
--cc=blaisorblade@yahoo.it \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox