public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Ulrich Drepper <drepper@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: Re: asm-x86/sigcontext.h changes break userland
Date: Wed, 13 Feb 2008 07:49:27 -0500	[thread overview]
Message-ID: <20080213124926.GM24887@devserv.devel.redhat.com> (raw)
In-Reply-To: <20080213072650.GA4363@elte.hu>

On Wed, Feb 13, 2008 at 08:26:50AM +0100, Ingo Molnar wrote:
> 
> * Jakub Jelinek <jakub@redhat.com> wrote:
> 
> > x86: use generic register names in struct sigcontext 
> > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=742fa54a62be6a263df14a553bf832724471dfbe
> > 
> > changeset breaks userland, e.g. it is not possible to compile gcc 
> > anymore (both 32-bit and 64-bit libgcc), and I expect any other 
> > program which pokes into struct sigcontext.  The register names with e 
> > resp. r have been in use for years, what's the point breaking it now?
> 
> ok - does the patch below solve the problem for you?

Yes, this fixes it.  Thanks.

FYI, gcc uses glibc headers to get at struct sigcontext, but
on i386 (and many other arches) glibc's <bits/sigcontext.h> just includes
<asm/sigcontext.h>.  On x86_64, ia64 and sparc* glibc doesn't include
asm/sigcontext.h, but provides its own definitions, so for gcc itself
only changing 32-bit parts woiuld be enough.  That said, there are certainly
programs which include asm/sigcontext.h directly (plus there are other c
libraries, some of which may use asm/sigcontext.h).

	Jakub

      reply	other threads:[~2008-02-13 12:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-13  0:15 asm-x86/sigcontext.h changes break userland Jakub Jelinek
2008-02-13  7:26 ` Ingo Molnar
2008-02-13 12:49   ` Jakub Jelinek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080213124926.GM24887@devserv.devel.redhat.com \
    --to=jakub@redhat.com \
    --cc=drepper@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox