From: Andrew Morton <akpm@linux-foundation.org>
To: minyard@acm.org
Cc: linux-kernel@vger.kernel.org, openipmi-developer@lists.sourceforge.net
Subject: Re: [PATCH 3/8] IPMI: Run to completion fixes
Date: Wed, 13 Feb 2008 15:20:18 -0800 [thread overview]
Message-ID: <20080213152018.98d427c7.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080213162342.GC9830@minyard.local>
On Wed, 13 Feb 2008 10:23:42 -0600
Corey Minyard <minyard@acm.org> wrote:
> From: Corey Minyard <cminyard@mvista.com>
>
> The "run_to_completion" mode was somewhat broken. Locks need to be
> avoided in run_to_completion mode, and it shouldn't be used by normal
> users, just internally for panic situations.
>
> This patch removes locks in run_to_completion mode and removes the
> user call for setting the mode. The only user was the poweroff
> code, but it was easily converted to use the polling interface.
>
> + /*
> + * Spin until our message is done.
> + */
> + while (atomic_read(&dummy_count) > 0) {
> + ipmi_poll_interface(user);
> + barrier();
> + }
we'd normally use cpu_relax() here.
next prev parent reply other threads:[~2008-02-13 23:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-13 16:23 [PATCH 3/8] IPMI: Run to completion fixes Corey Minyard
2008-02-13 23:20 ` Andrew Morton [this message]
2008-02-14 0:20 ` Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080213152018.98d427c7.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox