From: Andrew Morton <akpm@linux-foundation.org>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Russell King <rmk@arm.linux.org.uk>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] adfs: trivial sparse fix
Date: Wed, 13 Feb 2008 19:39:45 -0800 [thread overview]
Message-ID: <20080213193945.91b42a8d.akpm@linux-foundation.org> (raw)
In-Reply-To: <1202954868.18204.47.camel@brick>
On Wed, 13 Feb 2008 18:07:48 -0800 Harvey Harrison <harvey.harrison@gmail.com> wrote:
> fs/adfs/dir_f.c:126:4: warning: do-while statement is not a compound statement
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> ---
> fs/adfs/dir_f.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/adfs/dir_f.c b/fs/adfs/dir_f.c
> index b9b2b27..ea7df21 100644
> --- a/fs/adfs/dir_f.c
> +++ b/fs/adfs/dir_f.c
> @@ -122,9 +122,9 @@ adfs_dir_checkbyte(const struct adfs_dir *dir)
> ptr.ptr8 = bufoff(bh, i);
> end.ptr8 = ptr.ptr8 + last - i;
>
> - do
> + do {
> dircheck = *ptr.ptr8++ ^ ror13(dircheck);
> - while (ptr.ptr8 < end.ptr8);
> + } while (ptr.ptr8 < end.ptr8);
> }
>
eh? It's sparse which needs fixing here, surely?
next prev parent reply other threads:[~2008-02-14 3:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-14 2:07 [PATCH] adfs: trivial sparse fix Harvey Harrison
2008-02-14 3:39 ` Andrew Morton [this message]
2008-02-14 3:52 ` Harvey Harrison
2008-02-14 4:04 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080213193945.91b42a8d.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox