[2.6 patch] #if 0 aoedev_isbusy()

[2.6 patch] #if 0 aoedev_isbusy()

[Adrian Bunk]

This patch #if 0's the no longer used aoedev_isbusy().

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---

 drivers/block/aoe/aoe.h    |    1 -
 drivers/block/aoe/aoedev.c |    2 ++
 2 files changed, 2 insertions(+), 1 deletion(-)

3a516f0cdfe99486288c8379714dc17aa2c0d4b4 diff --git a/drivers/block/aoe/aoe.h b/drivers/block/aoe/aoe.h
index 280e71e..5b4c6e6 100644
--- a/drivers/block/aoe/aoe.h
+++ b/drivers/block/aoe/aoe.h
@@ -195,7 +195,6 @@ void aoedev_exit(void);
 struct aoedev *aoedev_by_aoeaddr(int maj, int min);
 struct aoedev *aoedev_by_sysminor_m(ulong sysminor);
 void aoedev_downdev(struct aoedev *d);
-int aoedev_isbusy(struct aoedev *d);
 int aoedev_flush(const char __user *str, size_t size);
 
 int aoenet_init(void);
diff --git a/drivers/block/aoe/aoedev.c b/drivers/block/aoe/aoedev.c
index f9a1cd9..2f481d9 100644
--- a/drivers/block/aoe/aoedev.c
+++ b/drivers/block/aoe/aoedev.c
@@ -18,6 +18,7 @@ static void skbpoolfree(struct aoedev *d);
 static struct aoedev *devlist;
 static DEFINE_SPINLOCK(devlist_lock);
 
+#if 0
 int
 aoedev_isbusy(struct aoedev *d)
 {
@@ -35,6 +36,7 @@ aoedev_isbusy(struct aoedev *d)
 	}
 	return 0;
 }
+#endif  /*  0  */
 
 struct aoedev *
 aoedev_by_aoeaddr(int maj, int min)

Re: [2.6 patch] #if 0 aoedev_isbusy()

[Jan Engelhardt]

On Feb 13 2008 23:30, Adrian Bunk wrote:
>
>This patch #if 0's the no longer used aoedev_isbusy().

Why not just remove it? (It can be resurrected from earlier
revisions should it be needed again.)

Re: [2.6 patch] #if 0 aoedev_isbusy()

[Adrian Bunk]

On Wed, Feb 13, 2008 at 11:03:35PM +0100, Jan Engelhardt wrote:
> 
> On Feb 13 2008 23:30, Adrian Bunk wrote:
> >
> >This patch #if 0's the no longer used aoedev_isbusy().
> 
> Why not just remove it? (It can be resurrected from earlier
> revisions should it be needed again.)

I've switched to doing #if 0 instead since this addresses the
"It might be needed in the future." answer I otherwise sometimes
got.

But if a maintainer wants to have such a function deleted instead that's 
fine with me.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [2.6 patch] #if 0 aoedev_isbusy()

[Ed L. Cashin]

On Thu, Feb 14, 2008 at 12:05:37AM +0200, Adrian Bunk wrote:
> On Wed, Feb 13, 2008 at 11:03:35PM +0100, Jan Engelhardt wrote:
> > 
> > On Feb 13 2008 23:30, Adrian Bunk wrote:
> > >
> > >This patch #if 0's the no longer used aoedev_isbusy().
> > 
> > Why not just remove it? (It can be resurrected from earlier
> > revisions should it be needed again.)
> 
> I've switched to doing #if 0 instead since this addresses the
> "It might be needed in the future." answer I otherwise sometimes
> got.
> 
> But if a maintainer wants to have such a function deleted instead that's 
> fine with me.

Hello.  That function can go away.  I have some changes pending, but
none of them use aoedev_isbusy.  Thanks for Cc-ing me.

-- 
  Ed L Cashin <ecashin@coraid.com>

[2.6 patch] remove aoedev_isbusy()

[Adrian Bunk]

On Wed, Feb 13, 2008 at 05:56:53PM -0500, Ed L. Cashin wrote:
> On Thu, Feb 14, 2008 at 12:05:37AM +0200, Adrian Bunk wrote:
> > On Wed, Feb 13, 2008 at 11:03:35PM +0100, Jan Engelhardt wrote:
> > > 
> > > On Feb 13 2008 23:30, Adrian Bunk wrote:
> > > >
> > > >This patch #if 0's the no longer used aoedev_isbusy().
> > > 
> > > Why not just remove it? (It can be resurrected from earlier
> > > revisions should it be needed again.)
> > 
> > I've switched to doing #if 0 instead since this addresses the
> > "It might be needed in the future." answer I otherwise sometimes
> > got.
> > 
> > But if a maintainer wants to have such a function deleted instead that's 
> > fine with me.
> 
> Hello.  That function can go away.  I have some changes pending, but
> none of them use aoedev_isbusy.  Thanks for Cc-ing me.

Updated patch below

cu
Adrian


<--  snip  -->


This patch removes the no longer used aoedev_isbusy().

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---

 drivers/block/aoe/aoe.h    |    1 -
 drivers/block/aoe/aoedev.c |   18 ------------------
 2 files changed, 19 deletions(-)

13d7ce5f6fa02341f1642f684847ce409bbd5b1d diff --git a/drivers/block/aoe/aoe.h b/drivers/block/aoe/aoe.h
index 280e71e..5b4c6e6 100644
--- a/drivers/block/aoe/aoe.h
+++ b/drivers/block/aoe/aoe.h
@@ -195,7 +195,6 @@ void aoedev_exit(void);
 struct aoedev *aoedev_by_aoeaddr(int maj, int min);
 struct aoedev *aoedev_by_sysminor_m(ulong sysminor);
 void aoedev_downdev(struct aoedev *d);
-int aoedev_isbusy(struct aoedev *d);
 int aoedev_flush(const char __user *str, size_t size);
 
 int aoenet_init(void);
diff --git a/drivers/block/aoe/aoedev.c b/drivers/block/aoe/aoedev.c
index f9a1cd9..a1d813a 100644
--- a/drivers/block/aoe/aoedev.c
+++ b/drivers/block/aoe/aoedev.c
@@ -18,24 +18,6 @@ static void skbpoolfree(struct aoedev *d);
 static struct aoedev *devlist;
 static DEFINE_SPINLOCK(devlist_lock);
 
-int
-aoedev_isbusy(struct aoedev *d)
-{
-	struct aoetgt **t, **te;
-	struct frame *f, *e;
-
-	t = d->targets;
-	te = t + NTARGETS;
-	for (; t < te && *t; t++) {
-		f = (*t)->frames;
-		e = f + (*t)->nframes;
-		for (; f < e; f++)
-			if (f->tag != FREETAG)
-				return 1;
-	}
-	return 0;
-}
-
 struct aoedev *
 aoedev_by_aoeaddr(int maj, int min)
 {