From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@ozlabs.org, benh@kernel.crashing.org
Cc: Christian Krafft <krafft@de.ibm.com>,
parabelboi@bopserverein.de, linux-kernel@vger.kernel.org
Subject: Re: [Patch 0/2] powerpc: avoid userspace poking to legacy ioports
Date: Thu, 14 Feb 2008 00:07:37 +0100 [thread overview]
Message-ID: <200802140007.38407.arnd@arndb.de> (raw)
In-Reply-To: <1202935374.7296.44.camel@pasglop>
On Wednesday 13 February 2008, Benjamin Herrenschmidt wrote:
> On Wed, 2008-02-13 at 18:35 +0100, Christian Krafft wrote:
> > sensors_detect crashes kernel on PowerPC, as it pokes directly to memory.
> > This patch adds a check_legacy_ioports to read_port and write_port.
> > It will now return ENXIO, instead of oopsing.
> >
> > Signed-off-by: Christian Krafft <krafft@de.ibm.com>
>
> The problem is that this prevents using /proc/ioports to access PCI
> IO space, which might be useful.
>
> I hate that sensors_detect.. or for that matter any other userland code
> that pokes random ports like that. It should die.
What kind of Oops do you get? Is it because the ioport area is not
ioremapped at all or do you get a machine check? If there is no
mapping, we could possibly change inb and outb do deal with that.
Arnd <><
next prev parent reply other threads:[~2008-02-13 23:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-13 17:28 [Patch 0/2] add check_legacy_ioport calls to prevent oops Christian Krafft
2008-02-13 17:35 ` [Patch 0/2] powerpc: avoid userspace poking to legacy ioports Christian Krafft
2008-02-13 20:42 ` Benjamin Herrenschmidt
2008-02-13 23:07 ` Arnd Bergmann [this message]
2008-02-18 20:15 ` Jean Delvare
2008-02-18 20:42 ` Benjamin Herrenschmidt
2008-02-18 20:58 ` Jean Delvare
2008-02-18 21:04 ` Arjan van de Ven
2008-02-18 21:05 ` Benjamin Herrenschmidt
2008-02-13 17:37 ` [Patch 2/2] powerpc: i2c-isa: add access check " Christian Krafft
2008-02-18 13:31 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802140007.38407.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=krafft@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=parabelboi@bopserverein.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox