From: "Uwe Kleine-König" <Uwe.Kleine-Koenig@digi.com>
To: linux-kernel@vger.kernel.org
Cc: David Brownell <dbrownell@users.sourceforge.net>,
Raphael Assenat <raph@8d.com>, Richard Purdie <rpurdie@rpsys.net>
Subject: Re: [PATCH] call gpio_cansleep only after gpio_request succeeded
Date: Thu, 14 Feb 2008 16:25:22 +0100 [thread overview]
Message-ID: <20080214152522.GA20123@digi.com> (raw)
In-Reply-To: <1202999569-9022-1-git-send-email-Uwe.Kleine-Koenig@digi.com>
Hello,
Uwe Kleine-König wrote:
> diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c
> index 6c0a9c4..76ddcf3 100644
> --- a/drivers/leds/leds-gpio.c
> +++ b/drivers/leds/leds-gpio.c
> @@ -79,6 +79,10 @@ static int gpio_led_probe(struct platform_device *pdev)
> cur_led = &pdata->leds[i];
> led_dat = &leds_data[i];
>
> + ret = gpio_request(led_dat->gpio, cur_led->name);
The line above must read:
ret = gpio_request(led_dat->gpio, cur_led->name);
I managed to notice that the 2nd argument needs a change but I
overlooked the first somehow.
Best regards
Uwe
--
Uwe Kleine-König, Software Engineer
Digi International GmbH Branch Breisach, Küferstrasse 8, 79206 Breisach, Germany
Tax: 315/5781/0242 / VAT: DE153662976 / Reg. Amtsgericht Dortmund HRB 13962
next prev parent reply other threads:[~2008-02-14 15:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-14 14:32 [PATCH] call gpio_cansleep only after gpio_request succeeded Uwe Kleine-König
2008-02-14 15:25 ` Uwe Kleine-König [this message]
2008-02-14 16:43 ` David Brownell
2008-03-06 10:24 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080214152522.GA20123@digi.com \
--to=uwe.kleine-koenig@digi.com \
--cc=dbrownell@users.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=raph@8d.com \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox