public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Andi Kleen <andi@firstfloor.org>
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org, torvalds@osdl.org
Subject: Re: [PATCH] Fix direct mapping alias regressin in ioremap v2
Date: Thu, 14 Feb 2008 18:42:37 +0100	[thread overview]
Message-ID: <20080214174237.GA24383@elte.hu> (raw)
In-Reply-To: <20080214165645.GA26748@basil.nowhere.org>


* Andi Kleen <andi@firstfloor.org> wrote:

>     Fix bug noticed by Ingo of __va() wrapping on 32bit

what you should realize is that had we applied your previous patch in a 
rush, it would have introduced a far more serious regression than the 
type of problem you are trying to solve. That's one of the reasons why 
we disagree with your sense of urgency.

We've got the clean fixes queued up and it's all under testing. (going 
fine so far)

Also, you only appear to have resent your fix with the obvious bug 
fixed, but it's still unclean and you do not seem to have replied to my 
main structural argument:

> > Please have a look at how we solved the "secondary alias" 64-bit 
> > problem in x86.git#mm and please resend against x86.git#mm if you 
> > still think something is missing. Thanks,

Thanks,

	Ingo

  reply	other threads:[~2008-02-14 17:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-14 16:56 [PATCH] Fix direct mapping alias regressin in ioremap v2 Andi Kleen
2008-02-14 17:42 ` Ingo Molnar [this message]
2008-02-14 21:34   ` Andi Kleen
2008-02-14 23:56     ` Ingo Molnar
2008-02-15  8:44       ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080214174237.GA24383@elte.hu \
    --to=mingo@elte.hu \
    --cc=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox