From: Ben Dooks <ben@fluff.org>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ubi: fix sparse errors in ubi.h
Date: Thu, 14 Feb 2008 23:56:37 +0000 [thread overview]
Message-ID: <20080214235637.GA4715@fluff.org.uk> (raw)
In-Reply-To: <1203025995.5601.0.camel@brick>
On Thu, Feb 14, 2008 at 01:53:15PM -0800, Harvey Harrison wrote:
> In C, signed 1-bit bitfields can only take the values 0 and -1, only
> 0 and 1 are ever assigned in current code. Make them unsigned
> bitfields.
>
> Fixes the (repeated) sparse errors:
> drivers/mtd/ubi/ubi.h:220:15: error: dubious one-bit signed bitfield
> drivers/mtd/ubi/ubi.h:221:17: error: dubious one-bit signed bitfield
> drivers/mtd/ubi/ubi.h:222:18: error: dubious one-bit signed bitfield
> drivers/mtd/ubi/ubi.h:223:16: error: dubious one-bit signed bitfield
> drivers/mtd/ubi/ubi.h:224:20: error: dubious one-bit signed bitfield
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> ---
> Sorry, not sure who to CC on this.
IIRC: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
--
Ben (ben@fluff.org, http://www.fluff.org/)
'a smiley only costs 4 bytes'
next prev parent reply other threads:[~2008-02-14 23:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-14 21:53 [PATCH] ubi: fix sparse errors in ubi.h Harvey Harrison
2008-02-14 23:56 ` Ben Dooks [this message]
2008-02-15 4:58 ` Joe Perches
2008-02-14 23:59 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080214235637.GA4715@fluff.org.uk \
--to=ben@fluff.org \
--cc=akpm@linux-foundation.org \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox